embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-02-10 12:46:29 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embark/core): fix(@embark/core): Fix recursive import remapping

Browse Source 
Remapping of imports was failing if the file had already had it’s import replaced with a pattern that would match with subsequent replacement attempts. For example, if the dapp contract contained
```
import ".embark/node_modules/zeppelin-solidity/contracts/ownership/Ownable.sol”;
```
which lives in `node_modules`, then `zeppelin-solidity/contracts/ownership/Ownable.sol` would be replaced with `.embark/node_modules/zeppelin-solidity/contracts/ownership/Ownable.sol`, resulting in:
```
import ".embark/node_modules/zeppelin-solidity/contracts/ownership/Ownable.sol";
```
On subsequent replacements of the same file, the same replacement would occur, resulting in the incorrect
```
import ".embark/node_modules/.embark/node_modules/zeppelin-solidity/contracts/ownership/Ownable.sol";
```
This commit is contained in:
emizzle 2019-02-01 10:00:41 +11:00 committed by Pascal Precht
parent 0ddebc7a80
commit e0fd641df9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/utils/solidity/remapImports.ts
View File

@ -128,7 +128,7 @@ const replaceImports = (remapImports: RemapImport[]) => {
Object.keys(byPath).forEach((p) => { Object.keys(byPath).forEach((p) => {
let source = fs.readFileSync(p, "utf-8"); let source = fs.readFileSync(p, "utf-8");
byPath[p].forEach(({searchValue, replaceValue}) => { byPath[p].forEach(({searchValue, replaceValue}) => {
source = source.replace(`${searchValue}`, `${replaceValue}`); source = source.replace(`import "${searchValue}"`, `import "${replaceValue}"`);
}); });
fs.writeFileSync(p, source); fs.writeFileSync(p, source);
}); });