embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@embark/proxy): Check if WebSocket open before sending (#1978) 

Add error handling to the proxy so that websocket frames are not sent on a socket that is not open.
This commit is contained in:
Eric Mastro 2019-10-22 02:23:34 +09:00 committed by Iuri Matias
parent a3b52676fc
commit db71a93bba
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/stack/proxy/src/proxy.js
View File

@ -45,8 +45,8 @@ export class Proxy {
if (ws) {
this.app.ws('/', async (ws, _wsReq) => {
// Watch from subscription data for events
this.requestManager.provider.on('data', function(result, deprecatedResult) {
ws.send(JSON.stringify(result || deprecatedResult))
this.requestManager.provider.on('data', (result, deprecatedResult) => {
this.respondWs(ws, result || deprecatedResult);
});
ws.on('message', async (msg) => {
@ -149,7 +149,16 @@ export class Proxy {
if (typeof response === "object") {
response = JSON.stringify(response);
}
ws.send(response);
if (ws.readyState === ws.OPEN) {
return ws.send(response);
}
const stateMap = {
0: "connecting",
1: "open",
2: "closing",
3: "closed"
};
this.logger.warn(`[Proxy]: Failed to send WebSocket response because the socket is ${stateMap[ws.readyState]}. Response: ${response}`);
}
respondHttp(res, statusCode, response) {
res.status(statusCode).send(response);