mirror of https://github.com/embarklabs/embark.git
fix(embark): specify "rxjs" as a dependency vs. "@reactivex/rxjs"
`"rxjs"` is [preferable][rxjs-pkg-name] in a CommonJS context, e.g. node. Existing embark code is `require`-ing from the unscoped package name, which worked in the monorepo because some other dependency specifies `"rxjs"` and yarn hoists it to the root of the workspace. In a production install of embark, though, `require('rxjs')` was failing. [rxjs-pkg-name]: https://github.com/ReactiveX/rxjs/issues/2577
This commit is contained in:
parent
e37598309f
commit
db40f03d68
|
@ -66,7 +66,6 @@
|
|||
"@babel/preset-react": "7.0.0",
|
||||
"@babel/preset-typescript": "7.1.0",
|
||||
"@babel/runtime-corejs2": "7.3.1",
|
||||
"@reactivex/rxjs": "6.4.0",
|
||||
"ajv": "6.5.5",
|
||||
"ascii-table": "0.0.9",
|
||||
"async": "2.6.1",
|
||||
|
@ -141,6 +140,7 @@
|
|||
"remix-debug-debugtest": "0.2.16",
|
||||
"remix-tests": "0.1.1",
|
||||
"request": "2.88.0",
|
||||
"rxjs": "6.4.0",
|
||||
"sass-loader": "7.1.0",
|
||||
"semver": "5.6.0",
|
||||
"serve-static": "1.13.2",
|
||||
|
|
14
yarn.lock
14
yarn.lock
|
@ -2167,13 +2167,6 @@
|
|||
universal-user-agent "^2.0.0"
|
||||
url-template "^2.0.8"
|
||||
|
||||
"@reactivex/rxjs@6.4.0":
|
||||
version "6.4.0"
|
||||
resolved "https://registry.yarnpkg.com/@reactivex/rxjs/-/rxjs-6.4.0.tgz#92a6813163beef132294a40e750f6054b7a74f0e"
|
||||
integrity sha512-Mn9PgWHzGG30w50TnBX4EUrMAkg8TOl255JfTfU0SK/FUD/Nq/NzEximIOQV5NXdu29aYJkLVDZ+gVStprO18g==
|
||||
dependencies:
|
||||
tslib "^1.9.0"
|
||||
|
||||
"@sinonjs/formatio@3.0.0":
|
||||
version "3.0.0"
|
||||
resolved "https://registry.yarnpkg.com/@sinonjs/formatio/-/formatio-3.0.0.tgz#9d282d81030a03a03fa0c5ce31fd8786a4da311a"
|
||||
|
@ -17013,6 +17006,13 @@ rustbn.js@~0.2.0:
|
|||
resolved "https://registry.yarnpkg.com/rustbn.js/-/rustbn.js-0.2.0.tgz#8082cb886e707155fd1cb6f23bd591ab8d55d0ca"
|
||||
integrity sha512-4VlvkRUuCJvr2J6Y0ImW7NvTCriMi7ErOAqWk1y69vAdoNIzCF3yPmgeNzx+RQTLEDFq5sHfscn1MwHxP9hNfA==
|
||||
|
||||
rxjs@6.4.0:
|
||||
version "6.4.0"
|
||||
resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.4.0.tgz#f3bb0fe7bda7fb69deac0c16f17b50b0b8790504"
|
||||
integrity sha512-Z9Yfa11F6B9Sg/BK9MnqnQ+aQYicPLtilXBp2yUtDt2JRCE0h26d33EnfO3ZxoNxG0T92OUucP3Ct7cpfkdFfw==
|
||||
dependencies:
|
||||
tslib "^1.9.0"
|
||||
|
||||
rxjs@^6.1.0:
|
||||
version "6.3.3"
|
||||
resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.3.3.tgz#3c6a7fa420e844a81390fb1158a9ec614f4bad55"
|
||||
|
|
Loading…
Reference in New Issue