embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-02-17 08:07:51 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #460 from embark-framework/fix_overridecompiler

Browse Source 
Allow plugins to override core compilers
This commit is contained in:
Iuri Matias 2018-06-15 16:39:09 -04:00 committed by GitHub
commit dae9e4ae7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/core/plugins.js
View File

@ -104,6 +104,17 @@ Plugins.prototype.getPluginsProperty = function(pluginType, property, sub_proper
return plugin.has(pluginType); return plugin.has(pluginType);
}); });
// Sort internal plugins first
matchingPlugins.sort((a, b) => {
if (a.isInternal) {
return -1;
}
if (b.isInternal) {
return 1;
}
return 0;
});
let matchingProperties = matchingPlugins.map((plugin) => { let matchingProperties = matchingPlugins.map((plugin) => {
if (sub_property) { if (sub_property) {
return plugin[property][sub_property]; return plugin[property][sub_property];
@ -111,6 +122,7 @@ Plugins.prototype.getPluginsProperty = function(pluginType, property, sub_proper
return plugin[property]; return plugin[property];
}); });
// Remove empty properties
matchingProperties = matchingProperties.filter((property) => property); matchingProperties = matchingProperties.filter((property) => property);
//return flattened list //return flattened list

1
test_apps/test_app/README.md
View File

@ -5,4 +5,3 @@ Test App for integration testing purposes.
```../../bin/embark test``` to see tests are working as expected ```../../bin/embark test``` to see tests are working as expected
```dist/index.html``` and ```dist/test.html``` to check different functionality ```dist/index.html``` and ```dist/test.html``` to check different functionality