embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

webpack mode should be 'none' unless embark's mode is 'production'

This commit is contained in:
Michael Bradley, Jr 2018-07-24 20:33:04 -05:00
parent 7676a59e7c
commit d784cd3ee3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/pipeline/webpackProcess.js
View File

@ -38,7 +38,7 @@ class WebpackProcess extends ProcessWrapper {
webpackRun(filename, options, includeModules, importsList, detectErrors, realCwd, callback) { webpackRun(filename, options, includeModules, importsList, detectErrors, realCwd, callback) {
const self = this; const self = this;
let defaultOptions = { let defaultOptions = {
mode: self.env === 'development' ? 'none' : 'production', mode: self.env === 'production' ? 'production' : 'none',
// devtool: self.env === 'development' ? 'source-map' : false, // devtool: self.env === 'development' ? 'source-map' : false,
// pipeline would need to copy .map files to dist/ target dir // pipeline would need to copy .map files to dist/ target dir
// note: generating full source maps ('source-map') roughly doubles build time // note: generating full source maps ('source-map') roughly doubles build time