embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(@embark): remove unnecessary `undefined` argument in calls of registerActionForEvent

This commit is contained in:
Michael Bradley, Jr 2019-11-19 10:34:17 -06:00 committed by Michael Bradley
parent b28054530d
commit d5ebdafb55
6 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/core/src/engine.ts
View File

@ -205,7 +205,7 @@ export class Engine {
if (this.plugins) { if (this.plugins) {
const plugin = this.plugins.createPlugin('coreservicesplugin', {}); const plugin = this.plugins.createPlugin('coreservicesplugin', {});
plugin.registerActionForEvent("embark:engine:started", undefined, (_params, cb) => { plugin.registerActionForEvent("embark:engine:started", (_params, cb) => {
this.servicesMonitor && this.servicesMonitor.startMonitor(); this.servicesMonitor && this.servicesMonitor.startMonitor();
cb(); cb();
}); });

2
packages/plugins/accounts-manager/src/index.ts
View File

@ -22,7 +22,7 @@ export default class AccountsManager {
this._web3 = null; this._web3 = null;
}); });
this.embark.registerActionForEvent("tests:config:updated", undefined, async (params, cb) => { this.embark.registerActionForEvent("tests:config:updated", async (params, cb) => {
// reset accounts backing variable as the accounts in config may have changed and // reset accounts backing variable as the accounts in config may have changed and
// web.eth.getAccounts may return a different value now // web.eth.getAccounts may return a different value now
this._accounts = null; this._accounts = null;

2
packages/plugins/rpc-manager/src/lib/eth_accounts.ts
View File

@ -21,7 +21,7 @@ export default class EthAccounts extends RpcModifier {
constructor(embark: Embark, rpcModifierEvents: Events) { constructor(embark: Embark, rpcModifierEvents: Events) {
super(embark, rpcModifierEvents); super(embark, rpcModifierEvents);
this.embark.registerActionForEvent("blockchain:proxy:response", undefined, this.checkResponseFor_eth_accounts.bind(this)); this.embark.registerActionForEvent("blockchain:proxy:response", this.checkResponseFor_eth_accounts.bind(this));
} }
private async checkResponseFor_eth_accounts(params: any, callback: Callback<any>) { private async checkResponseFor_eth_accounts(params: any, callback: Callback<any>) {

2
packages/plugins/rpc-manager/src/lib/eth_sendTransaction.ts
View File

@ -11,7 +11,7 @@ export default class EthSendTransaction extends RpcModifier {
constructor(embark: Embark, rpcModifierEvents: Events) { constructor(embark: Embark, rpcModifierEvents: Events) {
super(embark, rpcModifierEvents); super(embark, rpcModifierEvents);
embark.registerActionForEvent("blockchain:proxy:request", undefined, this.checkRequestFor_eth_sendTransaction.bind(this)); embark.registerActionForEvent("blockchain:proxy:request", this.checkRequestFor_eth_sendTransaction.bind(this));
// Allow to run transaction in parallel by resolving the nonce manually. // Allow to run transaction in parallel by resolving the nonce manually.
// For each transaction, resolve the nonce by taking the max of current transaction count and the cache we keep locally. // For each transaction, resolve the nonce by taking the max of current transaction count and the cache we keep locally.

4
packages/plugins/rpc-manager/src/lib/eth_signTypedData.ts
View File

@ -8,8 +8,8 @@ export default class EthSignTypedData extends RpcModifier {
constructor(embark: Embark, rpcModifierEvents: Events) { constructor(embark: Embark, rpcModifierEvents: Events) {
super(embark, rpcModifierEvents); super(embark, rpcModifierEvents);
this.embark.registerActionForEvent("blockchain:proxy:request", undefined, this.checkRequestFor_eth_signTypedData.bind(this)); this.embark.registerActionForEvent("blockchain:proxy:request", this.checkRequestFor_eth_signTypedData.bind(this));
this.embark.registerActionForEvent("blockchain:proxy:response", undefined, this.checkResponseFor_eth_signTypedData.bind(this)); this.embark.registerActionForEvent("blockchain:proxy:response", this.checkResponseFor_eth_signTypedData.bind(this));
} }
private async checkRequestFor_eth_signTypedData(params: any, callback: Callback<any>) { private async checkRequestFor_eth_signTypedData(params: any, callback: Callback<any>) {

2
packages/plugins/rpc-manager/src/lib/personal_newAccount.ts
View File

@ -7,7 +7,7 @@ export default class PersonalNewAccount extends RpcModifier {
constructor(embark: Embark, rpcModifierEvents: Events) { constructor(embark: Embark, rpcModifierEvents: Events) {
super(embark, rpcModifierEvents); super(embark, rpcModifierEvents);
embark.registerActionForEvent("blockchain:proxy:response", undefined, this.checkResponseFor_personal_newAccount.bind(this)); embark.registerActionForEvent("blockchain:proxy:response", this.checkResponseFor_personal_newAccount.bind(this));
} }
private async checkResponseFor_personal_newAccount(params: any, callback: Callback<any>) { private async checkResponseFor_personal_newAccount(params: any, callback: Callback<any>) {