From c24536d8a66acfbe731f17e6eab0cca048851201 Mon Sep 17 00:00:00 2001
From: emizzle <ericmastro@status.im>
Date: Thu, 6 Dec 2018 20:36:32 +1100
Subject: [PATCH] =?UTF-8?q?fix(@embark/core):=20Disable=20swarm=20if=20URL?=
 =?UTF-8?q?=20can=E2=80=99t=20be=20determined?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If the storage config is set up in such a way that a URL for swarm cannot be determined, the swarm module will exit early.

For example, if the storage config looks like:
```
available_providers: ["ipfs", "swarm"],
    upload: {
      provider: "ipfs",
      host: "localhost",
      port: 5001
    },
    dappConnection: [
      {
        provider:"ipfs",
        host: "localhost",
        port: 5001,
        getUrl: "http://localhost:8080/ipfs/"
      }
    ]
```
Then there is no way to determine the swarm URL as neither `upload` nor `dappConnection` specify a provider with `swarm`. If this is the case, the swarm module will exit in it’s constructor.

Add a warning message in the console for the users.
---
 src/lib/modules/swarm/index.js | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/lib/modules/swarm/index.js b/src/lib/modules/swarm/index.js
index b770f91f3..21a0bfa23 100644
--- a/src/lib/modules/swarm/index.js
+++ b/src/lib/modules/swarm/index.js
@@ -5,6 +5,7 @@ const SwarmAPI = require('swarm-api');
 // TODO: not great, breaks module isolation
 const StorageProcessesLauncher = require('../storage/storageProcessesLauncher');
 const constants = require('../../constants.json');
+require('colors');
 
 class Swarm {
 
@@ -20,13 +21,20 @@ class Swarm {
     this.webServerConfig = embark.config.webServerConfig;
     this.blockchainConfig = embark.config.blockchainConfig;
 
+    const cantDetermineUrl = this.storageConfig.upload.provider !== 'swarm' && !this.storageConfig.dappConnection.some(connection => connection.provider === 'swarm');
+
+    if(this.isSwarmEnabledInTheConfig() && cantDetermineUrl){
+      console.warn('\n===== Swarm module will not be loaded =====');
+      console.warn(`Swarm is enabled in the config, however the config is not setup to provide a URL for swarm and therefore the Swarm module will not be loaded. Please either change the ${'config/storage > upload'.bold} setting to Swarm or add the Swarm config to the ${'config/storage > dappConnection'.bold} array. Please see ${'https://embark.status.im/docs/storage_configuration.html'.underline} for more information.\n`);
+    }
+    if (!this.isSwarmEnabledInTheConfig() || cantDetermineUrl) {
+      return;
+    }
+
     this.providerUrl = utils.buildUrl(this.storageConfig.upload.protocol, this.storageConfig.upload.host, this.storageConfig.upload.port);
 
     this.getUrl = this.storageConfig.upload.getUrl || this.providerUrl + '/bzz:/';
 
-    if (!this.isSwarmEnabledInTheConfig()) {
-      return;
-    }
 
     this.swarm = new SwarmAPI({gateway: this.providerUrl});