diff --git a/packages/embark-test-runner/package.json b/packages/embark-test-runner/package.json index b4e198ddc..a2ffa0615 100644 --- a/packages/embark-test-runner/package.json +++ b/packages/embark-test-runner/package.json @@ -51,7 +51,8 @@ "embark-i18n": "^4.1.0", "embark-utils": "^4.1.0", "fs-extra": "7.0.1", - "mocha": "5.2.0" + "mocha": "5.2.0", + "open": "6.4.0" }, "devDependencies": { "@babel/cli": "7.2.3", diff --git a/packages/embark-test-runner/src/index.js b/packages/embark-test-runner/src/index.js index 2738769f8..614acff7c 100644 --- a/packages/embark-test-runner/src/index.js +++ b/packages/embark-test-runner/src/index.js @@ -92,12 +92,12 @@ class TestRunner { return next(err); } console.info(`Coverage report created. You can find it here: ${dappPath('coverage/index.html')}\n`); - const opn = require('opn'); + const open = require('open'); const _next = () => { next(null, results); }; if (options.noBrowser) { return next(null, results); } - opn(dappPath('coverage/index.html'), {wait: false}) + open(dappPath('coverage/index.html')) .then(() => timer(1000)) .then(_next, _next); }); diff --git a/packages/embark-webserver/package.json b/packages/embark-webserver/package.json index d49f78ad8..2a956ec12 100644 --- a/packages/embark-webserver/package.json +++ b/packages/embark-webserver/package.json @@ -53,7 +53,7 @@ "express": "4.16.3", "express-http-proxy": "1.5.1", "express-ws": "4.0.0", - "opn": "6.0.0", + "open": "6.4.0", "serve-static": "1.13.2" }, "devDependencies": { diff --git a/packages/embark-webserver/src/index.js b/packages/embark-webserver/src/index.js index d4d91315d..782b6101b 100644 --- a/packages/embark-webserver/src/index.js +++ b/packages/embark-webserver/src/index.js @@ -1,7 +1,7 @@ import { __ } from 'embark-i18n'; import {joinPath, canonicalHost, checkIsAvailable, findNextPort} from 'embark-utils'; var Server = require('./server.js'); -const opn = require('opn'); +const open = require('open'); require('ejs'); const Templates = { @@ -182,9 +182,8 @@ class WebServer { openBrowser(cb) { const _cb = () => { cb(); }; - return opn( - `${this.protocol}://${canonicalHost(this.server.hostname)}:${this.server.port}`, - {wait: false} + return open( + `${this.protocol}://${canonicalHost(this.server.hostname)}:${this.server.port}` ).then(_cb, _cb); // fail silently, e.g. in a docker container } } diff --git a/packages/embark/package.json b/packages/embark/package.json index d6f352162..6c70b98a6 100644 --- a/packages/embark/package.json +++ b/packages/embark/package.json @@ -166,7 +166,6 @@ "node-ipc": "9.1.1", "node-sass": "4.9.3", "npmlog": "4.1.2", - "opn": "6.0.0", "ora": "2.1.0", "os-locale": "3.0.1", "parse-json": "4.0.0", diff --git a/yarn.lock b/yarn.lock index 66b26fc7d..0c497dbb6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -15136,7 +15136,7 @@ onetime@^2.0.0: dependencies: mimic-fn "^1.0.0" -open@^6.1.0, open@^6.3.0: +open@6.4.0, open@^6.1.0, open@^6.3.0: version "6.4.0" resolved "https://registry.yarnpkg.com/open/-/open-6.4.0.tgz#5c13e96d0dc894686164f18965ecfe889ecfc8a9" integrity sha512-IFenVPgF70fSm1keSd2iDBIDIBZkroLeuffXq+wKTzTJlBpesFWojV9lb8mzOfaAzM1sr7HQHuO0vtV0zYekGg== @@ -15150,13 +15150,6 @@ opn@5.4.0, opn@^5.1.0: dependencies: is-wsl "^1.1.0" -opn@6.0.0: - version "6.0.0" - resolved "https://registry.yarnpkg.com/opn/-/opn-6.0.0.tgz#3c5b0db676d5f97da1233d1ed42d182bc5a27d2d" - integrity sha512-I9PKfIZC+e4RXZ/qr1RhgyCnGgYX0UEIlXgWnCOVACIvFgaC9rz6Won7xbdhoHrd8IIhV7YEpHjreNUNkqCGkQ== - dependencies: - is-wsl "^1.1.0" - optimist@^0.6.1: version "0.6.1" resolved "https://registry.yarnpkg.com/optimist/-/optimist-0.6.1.tgz#da3ea74686fa21a19a111c326e90eb15a0196686"