embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove unneded assigment; add clarification/TODO

This commit is contained in:
Iuri Matias 2018-05-18 20:32:40 -04:00 committed by Jonathan Rainville
parent a8e29976b7
commit ac45b7a19b
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/core/engine.js
View File

@ -281,11 +281,11 @@ class Engine {
web3: options.web3 web3: options.web3
}); });
this.web3 = this.blockchain.web3;
this.registerModule('whisper', { this.registerModule('whisper', {
addCheck: this.servicesMonitor.addCheck.bind(this.servicesMonitor), addCheck: this.servicesMonitor.addCheck.bind(this.servicesMonitor),
communicationConfig: this.config.communicationConfig, communicationConfig: this.config.communicationConfig,
// TODO: this should not be needed and should be deducted from the config instead
// the eth provider is not necessary the same as the whisper one
web3: this.web3 web3: this.web3
}); });
} }

1
lib/modules/whisper/index.js
View File

@ -8,6 +8,7 @@ class Whisper {
this.events = embark.events; this.events = embark.events;
this.communicationConfig = options.communicationConfig; this.communicationConfig = options.communicationConfig;
this.addCheck = options.addCheck; this.addCheck = options.addCheck;
// TODO: this should not be needed and should be deducted from the config instead
this.web3 = options.web3; this.web3 = options.web3;
this.embark = embark; this.embark = embark;