mirror of
https://github.com/embarklabs/embark.git
synced 2025-02-10 20:56:38 +00:00
review comments
This commit is contained in:
parent
c64c093a48
commit
9e69a7257e
@ -2,7 +2,6 @@
|
|||||||
|
|
||||||
let __embarkENS = {};
|
let __embarkENS = {};
|
||||||
|
|
||||||
const NOT_REGISTERED_ERROR = 'Name not yet registered';
|
|
||||||
// resolver interface
|
// resolver interface
|
||||||
__embarkENS.resolverInterface = [
|
__embarkENS.resolverInterface = [
|
||||||
{
|
{
|
||||||
@ -193,7 +192,7 @@ __embarkENS.resolve = function (name, callback) {
|
|||||||
return this.ens.methods.resolver(node).call()
|
return this.ens.methods.resolver(node).call()
|
||||||
.then(resolverAddress => {
|
.then(resolverAddress => {
|
||||||
if (resolverAddress === voidAddress) {
|
if (resolverAddress === voidAddress) {
|
||||||
return cb(NOT_REGISTERED_ERROR);
|
return cb('Name not yet registered');
|
||||||
}
|
}
|
||||||
let resolverContract = new EmbarkJS.Blockchain.Contract({
|
let resolverContract = new EmbarkJS.Blockchain.Contract({
|
||||||
abi: this.resolverInterface,
|
abi: this.resolverInterface,
|
||||||
@ -202,9 +201,7 @@ __embarkENS.resolve = function (name, callback) {
|
|||||||
});
|
});
|
||||||
return resolverContract.methods.addr(node).call(cb);
|
return resolverContract.methods.addr(node).call(cb);
|
||||||
})
|
})
|
||||||
.catch(err => {
|
.catch(cb);
|
||||||
cb(err);
|
|
||||||
});
|
|
||||||
};
|
};
|
||||||
|
|
||||||
__embarkENS.lookup = function (address, callback) {
|
__embarkENS.lookup = function (address, callback) {
|
||||||
@ -239,9 +236,7 @@ __embarkENS.lookup = function (address, callback) {
|
|||||||
});
|
});
|
||||||
return resolverContract.methods.name(node).call(cb);
|
return resolverContract.methods.name(node).call(cb);
|
||||||
})
|
})
|
||||||
.catch(err => {
|
.catch(cb);
|
||||||
cb(err);
|
|
||||||
});
|
|
||||||
};
|
};
|
||||||
|
|
||||||
__embarkENS.registerSubDomain = function (name, address, callback) {
|
__embarkENS.registerSubDomain = function (name, address, callback) {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user