embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-01-11 14:24:24 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embark/pipeline): ensure color methods for logs are available

Browse Source 
As part of 880a3a6946, we've introduced a
regression where the `colors` package isn't imported in the scope anymore where it's
needed. In this case the pipeline package. This resulted in log output messages
such as:

```
undefinedwriting fileundefined
```

Adding the `colors` package as dependency and importing it accordingly
fixes the issue.
This commit is contained in:
Pascal Precht 2019-05-16 10:49:10 +02:00 committed by Pascal Precht
parent a10bd69756
commit 8ca6419a4e
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/embark-pipeline/package.json
View File

@ -48,6 +48,7 @@
"dependencies": { "dependencies": {
"@babel/runtime-corejs2": "7.3.1", "@babel/runtime-corejs2": "7.3.1",
"async": "2.6.1", "async": "2.6.1",
"colors": "1.3.2",
"embark-core": "^4.1.0-beta.1", "embark-core": "^4.1.0-beta.1",
"embark-i18n": "^4.1.0-beta.1", "embark-i18n": "^4.1.0-beta.1",
"embark-utils": "^4.1.0-beta.1", "embark-utils": "^4.1.0-beta.1",

1
packages/embark-pipeline/src/webpackProcess.js
View File

@ -1,3 +1,4 @@
import 'colors';
import { ProcessWrapper } from 'embark-core'; import { ProcessWrapper } from 'embark-core';
import { dappPath, errorMessage } from 'embark-utils'; import { dappPath, errorMessage } from 'embark-utils';
const constants = require('embark-core/constants'); const constants = require('embark-core/constants');