PR feedback

This commit is contained in:
Anthony Laibe 2018-10-30 21:05:10 +01:00
parent 9276dd7805
commit 78d3189142
2 changed files with 11 additions and 11 deletions

View File

@ -31,14 +31,6 @@ class Console {
this.suggestions = new Suggestions(embark, options);
}
jsonReplacer(key, value) {
if (typeof value === 'function') {
return value.toString();
}
return value;
}
registerApi() {
let plugin = this.plugins.createPlugin('consoleApi', {});
plugin.registerAPICall('post', '/embark-api/command', (req, res) => {
@ -49,12 +41,11 @@ class Console {
if (typeof result === 'string') {
return res.send({result});
}
res.send({result: stringify(result, this.jsonReplacer, 2)});
res.send({result: stringify(result, utils.jsonFunctionReplacer, 2)});
});
});
}
processEmbarkCmd (cmd) {
if (cmd === 'help' || cmd === __('help') || cmd === '01189998819991197253') {
let helpText = [

View File

@ -524,6 +524,14 @@ function fuzzySearch(text, list, filter) {
return fuzzy.filter(text, list, {extract: (filter || function () {})});
}
function jsonFunctionReplacer(_key, value) {
if (typeof value === 'function') {
return value.toString();
}
return value;
}
module.exports = {
joinPath,
dirname,
@ -570,5 +578,6 @@ module.exports = {
timer,
fileTreeSort,
copyToClipboard,
fuzzySearch
fuzzySearch,
jsonFunctionReplacer
};