embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use properties where it makes sense

This commit is contained in:
Andre Medeiros 2018-10-03 14:56:08 -04:00 committed by Pascal Precht
parent 31cfc7bdeb
commit 777b0ff1e5
No known key found for this signature in database
GPG Key ID: 0EE28D8D6FD85D7D
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
embark-ui/src/containers/ApplicationPreviewContainer.js
View File

@ -1,3 +1,4 @@
import PropTypes from 'prop-types';
import React from 'react'; import React from 'react';
class ApplicationPreviewContainer extends React.Component { class ApplicationPreviewContainer extends React.Component {
@ -5,7 +6,8 @@ class ApplicationPreviewContainer extends React.Component {
super(props); super(props);
this.state = { this.state = {
previewUrl: 'http://localhost:8000' // TODO(andremedeiros): Figure out how to pull this from the actual host.
previewUrl: this.props.previewHomepage
}; };
} }
@ -18,7 +20,7 @@ class ApplicationPreviewContainer extends React.Component {
<button className="btn btn-outline-secondary" type="button" onClick={(e) => this.handlePreviewGo(e)}>Go</button> <button className="btn btn-outline-secondary" type="button" onClick={(e) => this.handlePreviewGo(e)}>Go</button>
</div> </div>
</div> </div>
<iframe width="100%" height="500" title="Preview" ref={(iframe) => this.previewIframe = iframe} onLoad={(e) => this.handlePreviewChange(e)} src="http://localhost:8000"></iframe> <iframe width="100%" height="500" title="Preview" ref={(iframe) => this.previewIframe = iframe} onLoad={(e) => this.handlePreviewChange(e)} src={this.props.previewHomepage}></iframe>
</div> </div>
); );
} }
@ -37,9 +39,17 @@ class ApplicationPreviewContainer extends React.Component {
} }
handlePreviewGo() { handlePreviewGo() {
this.previewIframe.src = this.previewUrl; this.previewIframe.src = this.state.previewUrl;
} }
} }
ApplicationPreviewContainer.propTypes = {
previewHomepage: PropTypes.string
};
ApplicationPreviewContainer.defaultProps = {
previewHomepage: 'http://localhost:8000'
};
export default ApplicationPreviewContainer; export default ApplicationPreviewContainer;