embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-01-23 12:11:16 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embark/deployment): ensure error messages emitted are logged

Browse Source 
Errors emitted as part of the `deployAll()` routine got swallowed by
Embark, leaving users in the unknown when the deployment process
"froze".

This commit ensures errors emitted are now logged, making it obvious
when something went wrong.
This commit is contained in:
Pascal Precht 2019-04-16 14:32:26 +02:00 committed by Pascal Precht
parent b8357b77bf
commit 72fc80df53
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/embark/src/lib/modules/deployment/contract_deployer.js
View File

@ -353,8 +353,11 @@ class ContractDeployer {
self.events.emit("deploy:contract:deployed", contract);
self.registerContract(contract, () => {
self.plugins.runActionsForEvent('deploy:contract:deployed', {contract: contract}, () => {
return next(null, receipt);
self.plugins.runActionsForEvent('deploy:contract:deployed', {contract: contract}, (err) => {
if (err) {
return next(err);
}
next(null, receipt);
});
});
}, hash => {

13
packages/embark/src/lib/modules/deployment/index.js
View File

@ -61,7 +61,7 @@ class DeployManager {
next();
});
},
function () {
function (next) {
const contractDeploys = {};
const errors = [];
contracts.forEach(contract => {
@ -97,17 +97,20 @@ class DeployManager {
_err = __("Error deploying contracts. Please fix errors to continue.");
self.logger.error(_err);
self.events.emit("outputError", __("Error deploying contracts, please check console"));
return done(_err);
return next(_err);
}
if (contracts.length === 0) {
self.logger.info(__("no contracts found"));
return done();
return next();
}
self.logger.info(__("finished deploying contracts"));
done(err);
next(err);
});
}
]);
], (err) => {
self.logger.error(err);
done(err);
});
});
});
}