embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #383 from embark-framework/no_contracts 

don't error if it's an empty dapp with no contracts yet
This commit is contained in:
Iuri Matias 2018-04-26 14:56:13 -04:00 committed by GitHub
parent 9e91915bce 3b736f56a7
commit 6a3add8e04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/contracts/compiler.js
View File

@ -10,6 +10,10 @@ class Compiler {
const self = this; const self = this;
let available_compilers = {}; let available_compilers = {};
if (contractFiles.length === 0) {
return cb(null, {});
}
let pluginCompilers = self.plugins.getPluginsProperty('compilers', 'compilers'); let pluginCompilers = self.plugins.getPluginsProperty('compilers', 'compilers');
pluginCompilers.forEach(function (compilerObject) { pluginCompilers.forEach(function (compilerObject) {
available_compilers[compilerObject.extension] = compilerObject.cb; available_compilers[compilerObject.extension] = compilerObject.cb;

7
lib/contracts/deploy.js
View File

@ -352,8 +352,9 @@ class Deploy {
deployAll(done) { deployAll(done) {
let self = this; let self = this;
this.logger.info("deploying contracts"); this.logger.info("deploying contracts");
let contracts = this.contractsManager.listContracts();
async.eachOfSeries(this.contractsManager.listContracts(), async.eachOfSeries(contracts,
function (contract, key, callback) { function (contract, key, callback) {
self.logger.trace(arguments); self.logger.trace(arguments);
self.checkAndDeployContract(contract, null, callback); self.checkAndDeployContract(contract, null, callback);
@ -364,6 +365,10 @@ class Deploy {
self.logger.error(err.message); self.logger.error(err.message);
self.logger.debug(err.stack); self.logger.debug(err.stack);
} }
if (contracts.length === 0) {
self.logger.info("no contracts found");
return done();
}
self.logger.info("finished deploying contracts"); self.logger.info("finished deploying contracts");
self.logger.trace(arguments); self.logger.trace(arguments);
done(err); done(err);