From 63831f61103023906db7343cb2e09c82d5785fab Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Tue, 4 Feb 2020 10:42:57 -0600 Subject: [PATCH] fix(@embark/dashboard): update dashboard's `logEntry` to match core/logger's `logFunction` `packages/embark/src/cmd/dashboard/dashboard.js` overwrites the logger instance's `logFunction` method with a method named `logEntry` defined on the class exported from `packages/embark/src/cmd/dashboard/monitor.js`. Update `logEntry` in the same way as `logFunction` was revised in #2184. --- packages/embark/src/cmd/dashboard/monitor.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/embark/src/cmd/dashboard/monitor.js b/packages/embark/src/cmd/dashboard/monitor.js index 9b21a86f7..4084cca97 100644 --- a/packages/embark/src/cmd/dashboard/monitor.js +++ b/packages/embark/src/cmd/dashboard/monitor.js @@ -104,16 +104,12 @@ class Monitor { this.screen.render(); } - logEntry() { - const args = Array.from(arguments); - const color = args[args.length - 1]; - args.splice(args.length - 1, 1); - this.logText.log(...args.filter(arg => arg !== undefined && arg !== null).map(arg => { - if (color) { - return typeof arg === 'object' ? util.inspect(arg, 2)[color] : arg[color]; - } - return typeof arg === 'object' ? util.inspect(arg, 2) : arg; - })); + logEntry(args, color) { + args = Array.isArray(args) ? args : [args]; + this.logText.log(...(args.filter(arg => arg ?? false).map(arg => { + if (typeof arg === 'object') arg = util.inspect(arg, 2); + return color ? arg[color] : arg; + }))); this.screen.render(); }