From 5d29ab1d428c6ea96d89093b32a75b54c18ed642 Mon Sep 17 00:00:00 2001 From: emizzle Date: Wed, 10 Oct 2018 23:29:43 +1100 Subject: [PATCH] Minor PR comments Removed a null check and intialised `this.context` to an empty object. --- cmd/cmd_controller.js | 2 +- embark-ui/src/reducers/selectors.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/cmd_controller.js b/cmd/cmd_controller.js index 2d4e21e8c..4fb60ae84 100644 --- a/cmd/cmd_controller.js +++ b/cmd/cmd_controller.js @@ -14,7 +14,7 @@ class EmbarkController { // set a default context. should be overwritten by an action // method before being used - this.context = [constants.contexts.any]; + this.context = {}; } initConfig(env, options) { diff --git a/embark-ui/src/reducers/selectors.js b/embark-ui/src/reducers/selectors.js index 3c170e564..00986cd15 100644 --- a/embark-ui/src/reducers/selectors.js +++ b/embark-ui/src/reducers/selectors.js @@ -53,7 +53,6 @@ export function getProcesses(state) { } export function getProcessLogs(state) { - if(!state.entities.processLogs.length) return []; const processLogsObj = state.entities.processLogs.reduce((processLogs, processLog) => { const existingProcessLog = processLogs[processLog.process]; if(!existingProcessLog || processLog.timestamp > existingProcessLog.timestamp){