embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-01-11 22:34:24 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #393 from embark-framework/bug_fix/js-files-not-watched

Browse Source 
Fix glob in Windows for chokidar
This commit is contained in:
Iuri Matias 2018-05-02 16:11:03 -04:00 committed by GitHub
commit 5974ab81bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/pipeline/watch.js
View File

@ -1,5 +1,6 @@
let chokidar = require('chokidar'); let chokidar = require('chokidar');
let path = require('path'); let path = require('path');
const _ = require('underscore');
let fs = require('../core/fs.js'); let fs = require('../core/fs.js');
@ -57,14 +58,16 @@ class Watch {
// workaround for imports issue // workaround for imports issue
// so embark reacts to changes made in imported js files // so embark reacts to changes made in imported js files
// chokidar glob patterns only work with front-slashes
if (!Array.isArray(files)) { if (!Array.isArray(files)) {
fileGlob = path.join(path.dirname(files), '**', '*.*'); fileGlob = path.join(path.dirname(files), '**', '*.*').replace(/\\/g, '/');
} else if (files.length === 1) { } else if (files.length === 1) {
fileGlob = path.join(path.dirname(files[0]), '**', '*.*'); fileGlob = path.join(path.dirname(files[0]), '**', '*.*').replace(/\\/g, '/');
} }
filesToWatch.push(fileGlob); filesToWatch.push(fileGlob);
} }
filesToWatch = _.uniq(filesToWatch);
this.watchFiles( this.watchFiles(
filesToWatch, filesToWatch,