add jshint exceptions and TODO

This commit is contained in:
Iuri Matias 2016-10-22 17:29:06 -04:00
parent fff31d6995
commit 4b1a16b100
2 changed files with 6 additions and 4 deletions

View File

@ -83,17 +83,17 @@ Deploy.prototype.checkAndDeployContract = function(contract, params, callback) {
self.deployTracker.save(); self.deployTracker.save();
self.logger.contractsState(self.contractsManager.contractsState()); self.logger.contractsState(self.contractsManager.contractsState());
// TODO: replace with separate process so it's isolated and with // TODO: replace evals with separate process so it's isolated and with
// a callback // a callback
if (contract.onDeploy !== undefined) { if (contract.onDeploy !== undefined) {
self.logger.info('executing onDeploy commands'); self.logger.info('executing onDeploy commands');
var abiGenerator = new ABIGenerator({}, self.contractsManager); var abiGenerator = new ABIGenerator({}, self.contractsManager);
web3 = self.web3; web3 = self.web3;
var abi = abiGenerator.generateContracts(false); var abi = abiGenerator.generateContracts(false);
eval(abi); eval(abi); // jshint ignore:line
var cmds = contract.onDeploy.join(';\n'); var cmds = contract.onDeploy.join(';\n');
eval(cmds); eval(cmds); // jshint ignore:line
} }
callback(); callback();

View File

@ -62,7 +62,9 @@ Test.prototype.deployAll = function(contractsConfig, cb) {
self.web3.eth.getAccounts(function(err, accounts) { self.web3.eth.getAccounts(function(err, accounts) {
var web3 = self.web3; var web3 = self.web3;
web3.eth.defaultAccount = accounts[0]; web3.eth.defaultAccount = accounts[0];
eval(result); // TODO: replace evals with separate process so it's isolated and with
// a callback
eval(result); // jshint ignore:line
cb(); cb();
}); });
}); });