mirror of https://github.com/embarklabs/embark.git
rev comment re: NODE_PATH in webpack config
This commit is contained in:
parent
e0fda460ba
commit
46c4aea520
|
@ -5,15 +5,15 @@
|
||||||
// in the dapp's own package.json, perhaps with a different version/range or
|
// in the dapp's own package.json, perhaps with a different version/range or
|
||||||
// other specifier
|
// other specifier
|
||||||
|
|
||||||
// NOTE: embark modifies process.env.NODE_PATH so that embark's own
|
// NOTE: embark modifies process.env.NODE_PATH so that when running dapp
|
||||||
// node_modules directory will be searched by node's require(). That allows an
|
// scripts in embark's child processes, embark's own node_modules directory
|
||||||
// ejected version of this config, inside a dapp, to function correctly without
|
// will be searched by node's require(); that allows an ejected version of this
|
||||||
// embark being an explicit dependency of the dapp. However, webpack and babel
|
// config, inside a dapp, to function correctly without embark being an
|
||||||
// do not directly support NODE_PATH, so in various parts of the config,
|
// explicit dependency of the dapp; however, webpack and babel do not directly
|
||||||
// modules such as plugins and presets must be resolved with
|
// support NODE_PATH, so in various parts of the config, modules such as babel
|
||||||
// require.resolve(). That is only necessary if a plugin/preset is in embark's
|
// plugins and presets must be resolved with require.resolve(); that is only
|
||||||
// node_modules; if it's in the dapp's node_modules then it can be specified
|
// necessary if a plugin/preset is in embark's node_modules vs. the dapp's
|
||||||
// directly
|
// node_modules
|
||||||
|
|
||||||
// there's a bug in pkg clone-deep re: regex; for now use lodash.clonedeep
|
// there's a bug in pkg clone-deep re: regex; for now use lodash.clonedeep
|
||||||
// see: https://github.com/jonschlinkert/clone-deep/pull/14
|
// see: https://github.com/jonschlinkert/clone-deep/pull/14
|
||||||
|
|
Loading…
Reference in New Issue