embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

move asset files check from index to pipeline; index shouldn't know about the internals

This commit is contained in:
Iuri Matias 2018-07-07 16:51:24 +03:00
parent 59478f19ff
commit 448593b36f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/index.js
View File

@ -211,9 +211,6 @@ class Embark {
return callback(null, true); return callback(null, true);
} }
engine.logger.info("Finished deploying".underline); engine.logger.info("Finished deploying".underline);
if (!engine.config.assetFiles || !Object.keys(engine.config.assetFiles).length) {
return callback();
}
engine.events.on('outputDone', (err) => { engine.events.on('outputDone', (err) => {
engine.logger.info(__("finished building").underline); engine.logger.info(__("finished building").underline);
callback(err, true); callback(err, true);

5
lib/pipeline/pipeline.js
View File

@ -4,7 +4,6 @@ const ProcessLauncher = require('../process/processLauncher');
const utils = require('../utils/utils.js'); const utils = require('../utils/utils.js');
const constants = require('../constants'); const constants = require('../constants');
require("babel-preset-react"); require("babel-preset-react");
require("babel-preset-es2015"); require("babel-preset-es2015");
require("babel-preset-es2016"); require("babel-preset-es2016");
@ -27,6 +26,10 @@ class Pipeline {
const importsList = {}; const importsList = {};
let placeholderPage; let placeholderPage;
if (!this.assetFiles || !Object.keys(this.assetFiles).length) {
return callback();
}
async.waterfall([ async.waterfall([
function createPlaceholderPage(next){ function createPlaceholderPage(next){
self.events.request('embark-building-placeholder', (html) => { self.events.request('embark-building-placeholder', (html) => {