From 3a15804fda57a1b3b39f1dd3b7d4baa96104ee2a Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Mon, 30 Jul 2018 14:31:24 -0400 Subject: [PATCH] remove engine param --- lib/core/engine.js | 2 +- lib/modules/graph/index.js | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/core/engine.js b/lib/core/engine.js index ffa805833..571b24889 100644 --- a/lib/core/engine.js +++ b/lib/core/engine.js @@ -81,7 +81,7 @@ class Engine { } graphService(_options) { - this.registerModule('graph', {engine: this}); + this.registerModule('graph'); } pipelineService(_options) { diff --git a/lib/modules/graph/index.js b/lib/modules/graph/index.js index 4055fbfd9..068379ddf 100644 --- a/lib/modules/graph/index.js +++ b/lib/modules/graph/index.js @@ -1,13 +1,10 @@ const Viz = require('viz.js'); const fs = require('fs'); -// TODO: refactor this class to use the plugin api and not refeneences directly class GraphGenerator { constructor(embark, options) { const self = this; this.events = embark.events; - // TODO: this is a very bad dependency to have here, needs to be refactored to use events, etc.. - this.engine = options.engine; this.events.setCommandHandler("graph:create", function(options, cb) { self.generate(options);