embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@embark/test-runner): make `--tx-details` option work again 

In https://github.com/embark-framework/embark/commit/87d92b6091 we've introduced a feature in our test runner
to report exact gas costs used when calling Smart Contract methods that
cause computation.

Embark keeps a list of deployed contracts in memory and for all transactions
happening during tests, it'll match them to the contracts that performed them
to produce the report logs.

Unfortunately, we've been [resetting that memory](https://github.com/embark-framework/embark/commit/87d92b6091#diff-92b4f79a0473160fe700440b1ced5204R140) of deployed contracts
after every test, making it practically impossible for Embark to find
matching contracts for any transactions, because contracts aren't necessarily
redeployed per spec, resulting in no additional transaction logs whatsoever.

This commit ensures that the memory is never erased and at the same time
ensures it's not leaking infinitely in case multiple contracts are
deployed multiple times in the same process over several specs.
This commit is contained in:
Pascal Precht 2019-07-09 16:25:03 +02:00 committed by Michael Bradley
parent 3590197c55
commit 2531fc1d26
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/embark-test-runner/src/reporter.js
View File

@ -55,7 +55,14 @@ class EmbarkSpec extends Base {
if (self.txDetails) { if (self.txDetails) {
self.embarkEvents.request('contracts:contract', receipt.className, (contract) => { self.embarkEvents.request('contracts:contract', receipt.className, (contract) => {
if (contract) { if (contract) {
let index = self.contracts.findIndex(c => c.className === contract.className);
// It's possible to deploy the same contract multiple times per test, so we need
// to make sure we replace the existing one with the new one.
if (index > -1) {
self.contracts[index] = contract;
} else {
self.contracts.push(contract); self.contracts.push(contract);
}
self.addressToContract = getAddressToContract(self.contracts, self.addressToContract); self.addressToContract = getAddressToContract(self.contracts, self.addressToContract);
} }
}); });
@ -145,7 +152,6 @@ class EmbarkSpec extends Base {
runner.on('test', function() { runner.on('test', function() {
self.stats.test.gasUsed = 0; self.stats.test.gasUsed = 0;
self.contracts = [];
}); });
runner.on('pass', function(test) { runner.on('pass', function(test) {