embarklabs/embark
2
0
Fork 0
mirror of https://github.com/embarklabs/embark.git synced 2025-01-11 14:24:24 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embark/config): disable webserver if pipeline is disabled

Browse Source 
The webserver's job is to serve files generated by Embark's built-in pipeline,
however, since v4 users can choose they front-end tool to take care of building,
bundling and packing their DApps. Usually these tools come with a built-in
dev server as well.

Therefore, when the pipeline is turned off (which also soon will be the default),
there's not need start a webserver.
This commit is contained in:
Pascal Precht 2019-06-11 10:49:00 +02:00 committed by Pascal Precht
parent 9e5c9c7f17
commit 24b53395b0
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/embark-webserver/src/index.js
View File

@ -16,6 +16,7 @@ class WebServer {
this.fs = embark.fs; this.fs = embark.fs;
this.buildDir = embark.config.buildDir; this.buildDir = embark.config.buildDir;
this.webServerConfig = embark.config.webServerConfig; this.webServerConfig = embark.config.webServerConfig;
if (!this.webServerConfig.enabled) { if (!this.webServerConfig.enabled) {
return; return;
} }

4
packages/embark/src/lib/core/config.js
View File

@ -532,6 +532,10 @@ Config.prototype.loadWebServerConfigFile = function() {
this.webServerConfig = webServerConfig; this.webServerConfig = webServerConfig;
} }
if (!this.pipelineConfig.enabled) {
this.webServerConfig.enabled = false;
}
this.events.emit('config:load:webserver', this.webServerConfig); this.events.emit('config:load:webserver', this.webServerConfig);
}; };