embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #790 from embark-framework/bugfix/solc-die 

Avoid Solc to die because of compilation
This commit is contained in:
Iuri Matias 2018-09-06 13:31:39 -04:00 committed by GitHub
parent bee3aa1fde 5957be9571
commit 18ab1ce101
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/core/processes/processWrapper.js
View File

@ -12,14 +12,15 @@ class ProcessWrapper {
* Manages the log interception so that all console.* get sent back to the parent process * Manages the log interception so that all console.* get sent back to the parent process
* Also creates an Events instance. To use it, just do `this.events.[on|request]` * Also creates an Events instance. To use it, just do `this.events.[on|request]`
* *
* @param {Options} _options Nothing for now * @param {Options} options pingParent: true by default
*/ */
constructor(_options) { constructor(options = {pingParent: true}) {
this.interceptLogs(); this.interceptLogs();
this.events = new Events(); this.events = new Events();
if(options.pingParent) {
this.pingParent(); this.pingParent();
} }
}
// Ping parent to see if it is still alive. Otherwise, let's die // Ping parent to see if it is still alive. Otherwise, let's die
pingParent() { pingParent() {

2
lib/modules/solidity/solcP.js
View File

@ -10,7 +10,7 @@ const NpmTimer = require('../library_manager/npmTimer');
class SolcProcess extends ProcessWrapper { class SolcProcess extends ProcessWrapper {
constructor(options){ constructor(options){
super(); super({pingParent: false});
this._logger = options.logger; this._logger = options.logger;
this._showSpinner = options.showSpinner === true; this._showSpinner = options.showSpinner === true;
} }