Fix/solo spawn (#1981)

* build(@embark/stack/blockchain-client): remove unneeded typescript related scripts and deps

In addition to being unneeded their presence is causing build errors.

* build(embark): remove unneeded typescript related scripts and deps

In addition to being unneeded their presence is causing build errors.

* build(@embark/plugins/ethereum-blockchain-client): remove unneeded typescript related scripts, deps

In addition to being unneeded their presence is causing build errors.

* build(@embark/plugins/ganache): remove unneeded typescript related scripts and deps

In addition to being unneeded their presence is causing build errors.

* build(@embark/plugins/geth): remove unneeded typescript related scripts and deps

In addition to being unneeded their presence is causing build errors.

* fix(@embark/plugins/transaction-logger): require 'web3' not 'Web3'

* fix(@embark/utils/solo): spawn npm(.cmd) instead of npx(.cmd)

* test(@embark/plugins/basic-pipeline): add test stub

* test(@embark/stack/blockchain): add test stub
This commit is contained in:
Michael Bradley 2019-10-22 08:27:28 -05:00 committed by Iuri Matias
parent 2193d82399
commit 183d9a05b5
12 changed files with 40 additions and 60 deletions

View File

@ -39,16 +39,11 @@
"_build": "npm run solo -- build",
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "npm-run-all lint:*",
"lint:js": "eslint bin/embark src/bin/ src/lib/",
"lint:ts": "tslint -c tslint.json \"src/**/*.ts\"",
"qa": "npm-run-all lint typecheck _build test",
"lint": "eslint bin/embark src/bin/ src/lib/",
"qa": "npm-run-all lint _build test",
"reset": "npx rimraf .nyc_output coverage dist embark-*.tgz package",
"solo": "embark-solo",
"test": "nyc --reporter=html --reporter=json mocha \"dist/test/**/*.js\" --exit --no-timeouts --require ./scripts/test.js --require source-map-support/register",
"typecheck": "tsc",
"watch": "run-p watch:*",
"watch:typecheck": "npm run typecheck -- --preserveWatchOutput --watch"
"test": "nyc --reporter=html --reporter=json mocha \"dist/test/**/*.js\" --exit --no-timeouts --require ./scripts/test.js --require source-map-support/register"
},
"eslintConfig": {
"extends": "../../.eslintrc.json"
@ -235,9 +230,7 @@
"nyc": "13.1.0",
"rejected-or-not": "1.0.1",
"rimraf": "3.0.0",
"sinon": "4.5.0",
"tslint": "5.16.0",
"typescript": "3.6.3"
"sinon": "4.5.0"
},
"engines": {
"node": ">=8.12.0 <12.0.0",

View File

@ -1,3 +0,0 @@
export class Core {
}

View File

@ -33,7 +33,7 @@
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"qa": "npm-run-all lint _build test",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"test": "jest"

View File

@ -0,0 +1,7 @@
import BasicPipeline from '../src/index';
describe('needs tests', () => {
it('should have tests, please write them', () => {
expect(true).toBe(true);
});
});

View File

@ -32,14 +32,10 @@
"_build": "npm run solo -- build",
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "npm-run-all lint:*",
"lint:ts": "tslint -c tslint.json \"src/**/*.ts\"",
"qa": "npm-run-all lint typecheck _build",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"typecheck": "tsc",
"watch": "run-p watch:*",
"watch:typecheck": "npm run typecheck -- --preserveWatchOutput --watch"
"solo": "embark-solo"
},
"eslintConfig": {
"extends": "../../../.eslintrc.json"
@ -58,9 +54,7 @@
"embark-solo": "^4.1.1",
"eslint": "5.7.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.0",
"tslint": "5.16.0",
"typescript": "3.6.3"
"rimraf": "3.0.0"
},
"engines": {
"node": ">=8.12.0 <12.0.0",

View File

@ -32,14 +32,10 @@
"_build": "npm run solo -- build",
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "npm-run-all lint:*",
"lint:ts": "tslint -c tslint.json \"src/**/*.ts\"",
"qa": "npm-run-all lint typecheck _build",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"typecheck": "tsc",
"watch": "run-p watch:*",
"watch:typecheck": "npm run typecheck -- --preserveWatchOutput --watch"
"solo": "embark-solo"
},
"eslintConfig": {
"extends": "../../../.eslintrc.json"
@ -52,9 +48,7 @@
"embark-solo": "^4.1.1",
"eslint": "5.7.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.0",
"tslint": "5.16.0",
"typescript": "3.6.3"
"rimraf": "3.0.0"
},
"engines": {
"node": ">=8.12.0 <12.0.0",

View File

@ -32,14 +32,10 @@
"_build": "npm run solo -- build",
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "npm-run-all lint:*",
"lint:ts": "tslint -c tslint.json \"src/**/*.ts\"",
"qa": "npm-run-all lint typecheck _build",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"typecheck": "tsc",
"watch": "run-p watch:*",
"watch:typecheck": "npm run typecheck -- --preserveWatchOutput --watch"
"solo": "embark-solo"
},
"eslintConfig": {
"extends": "../../../.eslintrc.json"
@ -60,9 +56,7 @@
"embark-solo": "^4.1.1",
"eslint": "5.7.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.0",
"tslint": "5.16.0",
"typescript": "3.6.3"
"rimraf": "3.0.0"
},
"engines": {
"node": ">=8.12.0 <12.0.0",

View File

@ -1,6 +1,6 @@
const async = require('async');
import {__} from 'embark-i18n';
const Web3 = require('Web3');
const Web3 = require('web3');
const {blockchain: blockchainConstants} = require('embark-core/constants');
import {dappPath, getAddressToContract, getTransactionParams, hexToNumber} from 'embark-utils';

View File

@ -32,14 +32,10 @@
"_build": "npm run solo -- build",
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "npm-run-all lint:*",
"lint:ts": "tslint -c tslint.json \"src/**/*.ts\"",
"qa": "npm-run-all lint typecheck _build",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"typecheck": "tsc",
"watch": "run-p watch:*",
"watch:typecheck": "npm run typecheck -- --preserveWatchOutput --watch"
"solo": "embark-solo"
},
"eslintConfig": {
"extends": "../../../.eslintrc.json"
@ -52,9 +48,7 @@
"embark-solo": "^4.1.1",
"eslint": "5.7.0",
"npm-run-all": "4.1.5",
"rimraf": "3.0.0",
"tslint": "5.16.0",
"typescript": "3.6.3"
"rimraf": "3.0.0"
},
"engines": {
"node": ">=8.12.0 <12.0.0",

View File

@ -33,7 +33,7 @@
"ci": "npm run qa",
"clean": "npm run reset",
"lint": "eslint src/",
"qa": "npm-run-all lint _build",
"qa": "npm-run-all lint _build test",
"reset": "npx rimraf dist embark-*.tgz package",
"solo": "embark-solo",
"test": "jest"
@ -71,7 +71,7 @@
"**/test/**/*.js"
],
"transform": {
"\\.js$": [
"\\.(js|ts)$": [
"babel-jest",
{
"rootMode": "upward"

View File

@ -0,0 +1,7 @@
import Blockchain from '../src/index';
describe('needs tests', () => {
it('should have tests, please write them', () => {
expect(true).toBe(true);
});
});

View File

@ -24,7 +24,7 @@ module.exports = function (cliArgs) {
join(embarkCollectivePath, 'package.json')
);
const npxCmd = process.platform === 'win32' ? 'npx.cmd': 'npx';
const npmCmd = process.platform === 'win32' ? 'npm.cmd': 'npm';
process.chdir(embarkCollectivePath);
spawn(npxCmd, ['run', '--', ...cliArgs], {stdio: 'inherit'});
spawn(npmCmd, ['run', '--', ...cliArgs], {stdio: 'inherit'});
};