embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #366 from embark-framework/bug_fix/fix-ready-printed-before-complete 

Moved console "ready" message to write after outputDone event is emitted
This commit is contained in:
Iuri Matias 2018-04-17 08:38:49 -04:00 committed by GitHub
parent ad136802da a3d2cc9a2c
commit 114bf7ff64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/index.js
View File

@ -118,6 +118,11 @@ class Embark {
});
});
engine.events.on('outputDone', function () {
engine.logger.info("Looking for documentation? You can find it at ".cyan + "http://embark.readthedocs.io/".green.underline + ".".cyan);
engine.logger.info("Ready".underline);
});
engine.deployManager.deployContracts(function (err) {
engine.startService("fileWatcher");
if (options.runWebserver) {
@ -136,8 +141,6 @@ class Embark {
} else {
engine.events.emit('firstDeploymentDone');
engine.events.emit("status", "Ready".green);
engine.logger.info("Looking for documentation? you can find it at ".cyan + "http://embark.readthedocs.io/".green.underline);
engine.logger.info("Ready".underline);
let size = windowSize.get();
if (size.height < 40 || size.width < 118) {
@ -249,7 +252,6 @@ class Embark {
resetCmd();
}
// TODO: should deploy if it hasn't already
upload(platform, options) {
options.buildDir = 'dist/';