embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #799 from embark-framework/feature/trace-console-log 

Use trace logger for code runner error
This commit is contained in:
Jonathan Rainville 2018-09-12 09:55:47 -04:00 committed by GitHub
parent b3b8374d00 16c870ac34
commit 0f635f8a33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/modules/coderunner/codeRunner.js
View File

@ -8,7 +8,7 @@ class CodeRunner {
this.events = options.events; this.events = options.events;
this.ipc = options.ipc; this.ipc = options.ipc;
this.commands = []; this.commands = [];
this.runCode = new RunCode(); this.runCode = new RunCode({logger: this.logger});
this.registerIpcEvents(); this.registerIpcEvents();
this.IpcClientListen(); this.IpcClientListen();
this.registerEvents(); this.registerEvents();

5
lib/core/modules/coderunner/runCode.js
View File

@ -1,7 +1,8 @@
const vm = require('vm'); const vm = require('vm');
class RunCode { class RunCode {
constructor() { constructor({logger}) {
this.logger = logger;
this.context = Object.assign({}, {global, console, exports, require, module, __filename, __dirname}); this.context = Object.assign({}, {global, console, exports, require, module, __filename, __dirname});
} }
@ -9,7 +10,7 @@ class RunCode {
try { try {
return vm.runInNewContext(code, this.context); return vm.runInNewContext(code, this.context);
} catch(e) { } catch(e) {
console.error(e.message); this.logger.error(e.message);
} }
} }