embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@embark/pipeline): make generateAll async so it completes tasks 

generateAll was async, but it called the write functions with a sync
loop, so at the end of the function, the files were not written yet.
This is a problem in `embark build` because the process ends after
genrateAll is done, so no artifacts were written
This commit is contained in:
Jonathan Rainville 2020-01-23 14:27:10 -05:00
parent c891c2de95
commit 0a4d13f64c
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/stack/pipeline/src/index.js
View File

@ -30,14 +30,12 @@ class Pipeline {
}, },
(next) => { (next) => {
// TODO: make this async // TODO: make this async
for (let fileParams of Object.values(this.files)) { async.each(Object.values(this.files), (fileParams, eachCb) => {
if (fileParams.format === 'json') { if (fileParams.format === 'json') {
this.writeJSONFile(fileParams); return this.writeJSONFile(fileParams, eachCb);
} else {
this.writeFile(fileParams);
} }
} this.writeFile(fileParams, eachCb);
next(); }, next);
}, },
(next) => { (next) => {
this.plugins.runActionsForEvent("pipeline:generateAll:after", {}, (err) => { this.plugins.runActionsForEvent("pipeline:generateAll:after", {}, (err) => {
@ -49,7 +47,7 @@ class Pipeline {
}); });
} }
writeJSONFile(params) { writeJSONFile(params, cb) {
const self = this; const self = this;
const dir = dappPath(...params.path); const dir = dappPath(...params.path);
const filename = dappPath(...params.path, params.file); const filename = dappPath(...params.path, params.file);
@ -60,14 +58,13 @@ class Pipeline {
self.fs.mkdirp(dir, err => next(err)); self.fs.mkdirp(dir, err => next(err));
}, },
function writeContractsJSON(next) { function writeContractsJSON(next) {
self.fs.writeJson(filename, content, { spaces: 2 }, () => { next(); }); self.fs.writeJson(filename, content, { spaces: 2 }, (e) => { next(e); });
} }
], () => { ], cb);
});
} }
// TODO: can be refactored by joining with method above // TODO: can be refactored by joining with method above
writeFile(params) { writeFile(params, cb) {
const self = this; const self = this;
const dir = dappPath(...params.path); const dir = dappPath(...params.path);
const filename = dappPath(...params.path, params.file); const filename = dappPath(...params.path, params.file);
@ -78,10 +75,9 @@ class Pipeline {
self.fs.mkdirp(dir, err => next(err)); self.fs.mkdirp(dir, err => next(err));
}, },
function writeFile(next) { function writeFile(next) {
self.fs.writeFile(filename, content, (err) => { next(err, true); }); self.fs.writeFile(filename, content, (err) => { next(err); });
} }
], () => { ], cb);
});
} }
} }