From eb7a0b905c116be77b46d62721600335c834e958 Mon Sep 17 00:00:00 2001 From: Jonathan Rainville Date: Wed, 12 Sep 2018 09:37:27 -0400 Subject: [PATCH 1/2] fix missing argument --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index c7be297..d07f7a9 100644 --- a/index.js +++ b/index.js @@ -3,7 +3,7 @@ const Compiler = require("./lib/Compiler"); module.exports = (embark) => { embark.registerCompiler('.sol', compileSolc); - function compileSolc(contractFiles, cb) { + function compileSolc(contractFiles, options, cb) { if(!contractFiles || !contractFiles.length) { return cb(); } From eb0c51fe302a2f0f365a95043cb6dcd26692adcc Mon Sep 17 00:00:00 2001 From: Jonathan Rainville Date: Wed, 12 Sep 2018 09:38:03 -0400 Subject: [PATCH 2/2] do not exit on not installed --- lib/Compiler.js | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Compiler.js b/lib/Compiler.js index a3f2b95..e7da580 100644 --- a/lib/Compiler.js +++ b/lib/Compiler.js @@ -35,9 +35,9 @@ function compileSolc(embark, contractFiles, cb) { const solc = shelljs.which('solc'); if (!solc) { - logger.warn('solc is not installed on your machine'); + logger.error('solc is not installed on your machine'); logger.info('You can install it by following the instructions on: http://solidity.readthedocs.io/en/latest/installing-solidity.html'); - process.exit(); + return cb('Compiler not installed'); } logger.info("compiling solidity contracts with command line solc..."); diff --git a/package.json b/package.json index f5da44d..5d554f9 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "plugin", "contracts", "ethereum", - "embark" + "embark" ], "author": "Richard Ramos", "license": "ISC",