Removed cache lookup option

README.md

@@ -57,14 +57,13 @@ $ npm i flex-dapps/embark-mythx
 ## Usage
 
 ```bash
-verify [--full] [--debug] [--no-cache-lookup] [--limit] [--initial-delay] [<contracts>]
+verify [--full] [--debug] [--limit] [--initial-delay] [<contracts>]
 verify status <uuid>
 verify help
 
 Options:
-	--full, -f		Perform full instead of quick analysis.
+	--full, -f		Perform full instead of quick analysis (not available on free MythX tier).
 	--debug, -d		Additional debug output.
-	--no-cache-lookup, -c	Skip MythX-side cache lookup of report.
 	--limit, -l		Maximum number of concurrent analyses.
 	--initial-delay, -i	Time in seconds before first analysis status check.
 

index.js

@@ -65,14 +65,13 @@ module.exports = function(embark) {
 	function help() {
 		return (
 			"Usage:\n" +
-			"\tverify [--full] [--debug] [--no-cache-lookup] [--limit] [--initial-delay] [<contracts>]\n" +
+			"\tverify [--full] [--debug] [--limit] [--initial-delay] [<contracts>]\n" +
 			"\tverify status <uuid>\n" +
 			"\tverify help\n" +
 			"\n" + 
 			"Options:\n" + 
 			"\t--full, -f\t\t\tPerform full rather than quick analysis.\n" + 
 			"\t--debug, -d\t\t\tAdditional debug output.\n" + 
-			"\t--no-cache-lookup, -c\t\tSkip MythX-side cache lookup of report.\n" +
 			"\t--limit, -l\t\t\tMaximum number of concurrent analyses.\n" + 
 			"\t--initial-delay, -i\t\tTime in seconds before first analysis status check.\n" + 
 			"\n" + 
@@ -115,7 +114,6 @@ module.exports = function(embark) {
 		const optionDefinitions = [
 			{ name: 'full', alias: 'f', type: Boolean },
 			{ name: 'debug', alias: 'd', type: Boolean },
-			{ name: 'no-cache-lookup', alias: 'c', type: Boolean },
 			{ name: 'limit', alias: 'l', type: Number },
 			{ name: 'initial-delay', alias: 'i', type: Number },
 			{ name: 'contracts', type: String, multiple: true, defaultOption: true }

mythx.js

@@ -101,7 +101,6 @@ const doAnalysis = async (armletClient, config, contracts, contractNames = null,
 
     const timeout = (config.timeout || 300) * 1000;
     const initialDelay = ('initial-delay' in config) ? config['initial-delay'] * 1000 : undefined;
-    const noCacheLookup = ('no-cache-lookup' in config) ? config['no-cache-lookup'] : true;
 
     const results = await asyncPool(limit, contracts, async buildObj => {
         
@@ -109,7 +108,6 @@ const doAnalysis = async (armletClient, config, contracts, contractNames = null,
 
         let analyzeOpts = {
             clientToolName: 'embark-mythx',
-            noCacheLookup,
             timeout,
             initialDelay
         };
@@ -135,6 +133,7 @@ const doAnalysis = async (armletClient, config, contracts, contractNames = null,
             
             return [null, obj];
         } catch (err) {
+            //console.log("catch", JSON.stringify(err));
             let errStr;
             if (typeof err === 'string') {
                 errStr = `${err}`;