embarklabs
/
embark-mythx
mirror of https://github.com/embarklabs/embark-mythx.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix Embark logger usage 

The MythX plugin passes a single method of embark's logger to other APIs which breaks their
usage as a logger instance context is required inside each logger method.

This commit changes the plugin to pass around the entire logger instance instead of just
its log method.
This commit is contained in:
Pascal Precht 2020-01-22 13:52:43 +01:00
parent 89b16de8b6
commit 410267b0df
No known key found for this signature in database
GPG Key ID: 0EE28D8D6FD85D7D
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mythx.js
View File

@ -90,7 +90,7 @@ async function getStatus(uuid, embark) {
try {
const results = await armletClient.getIssues(uuid);
return ghettoReport(embark.logger.info, results);
return ghettoReport(embark.logger, results);
} catch (err) {
embark.logger.warn(err);
return 1;
@ -172,13 +172,13 @@ function ghettoReport(logger, results) {
});
if (issuesCount === 0) {
logger('No issues found');
logger.info('No issues found');
return 0;
}
for (const group of results) {
logger(group.sourceList.join(', ').underline);
logger.info(group.sourceList.join(', ').underline);
for (const issue of group.issues) {
logger(yaml.safeDump(issue, {'skipInvalid': true}));
logger.info(yaml.safeDump(issue, {'skipInvalid': true}));
}
}
return 1;