embarklabs/EmbarkJS
2
0
Fork 0
mirror of https://github.com/embarklabs/EmbarkJS.git synced 2025-02-19 23:58:16 +00:00
Code Issues Projects Releases Wiki Activity

fix(@embarkjs): fix unhandled promise rejection

Browse Source 
Previously, after EmbarkJS checked for working storage dappConnections but couldn’t find any that worked, there was an unhandled promise rejection error being logged.

The cause of this was because there was a new error being thrown inside of the `async.detectSeries` callback function (the function that executes after `detectSeries` completes). This new error was being caught by a try/catch block inside of the `detectSeries` loop.

To fix the issue, there is no new error being thrown, instead the error is logged to the console.
This commit is contained in:
emizzle 2018-11-28 17:54:47 +11:00
parent c2c8c811ab
commit 5da7aab5d6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage.js
View File

@ -98,10 +98,10 @@ Storage.setProviders = async function (dappConnOptions) {
}
}
}, function(err, result){
if(!result) throw new Error('Could not connect to a storage provider using any of the dappConnections in the storage config');
if(!result) console.error('Could not connect to a storage provider using any of the dappConnections in the storage config');
});
} catch (err) {
throw new Error('Failed to connect to a storage provider: ' + err.message);
console.error('Failed to connect to a storage provider: ' + err.message);
}
};