Merge pull request #31 from embark-framework/refactor/extract-web3

Extract Web3 from Blockchain and into a plugin
This commit is contained in:
Iuri Matias 2018-12-07 18:26:04 -05:00 committed by GitHub
commit 3856564232
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 119 additions and 247 deletions

View File

@ -4,7 +4,7 @@
"description": "JavaScript library for easily interacting with web3 technologies", "description": "JavaScript library for easily interacting with web3 technologies",
"main": "dist/node/index.js", "main": "dist/node/index.js",
"browser": { "browser": {
"./dist/node/index.js": "./dist/browser/browser.js" "./dist/node/index.js": "./dist/browser/index.js"
}, },
"browserslist": [ "browserslist": [
"last 1 version", "last 1 version",

View File

@ -1,42 +1,48 @@
import {reduce} from './async' /*global ethereum*/
import {reduce} from './async';
let Blockchain = {}; let Blockchain = {};
let contracts = []; let contracts = [];
function isNewWeb3_1() { Blockchain.Providers = {};
return (typeof(web3.version) === "string");
}
function getAccounts(cb) { Blockchain.registerProvider = function(providerName, obj) {
if (isNewWeb3_1()) { this.Providers[providerName] = obj;
return web3.eth.getAccounts().then(function(accounts) { };
return cb(null, accounts);
}).catch(function(err) { Blockchain.setProvider = function(providerName, options) {
return cb(err); let provider = this.Providers[providerName];
});
if (!provider) {
throw new Error('Unknown blockchain provider. ' +
'Make sure to register it first using EmbarkJS.Blockchain.registerProvider(providerName, providerObject');
} }
web3.eth.getAccounts(cb);
} this.currentProviderName = providerName;
this.blockchainConnector = provider;
provider.init(options);
};
Blockchain.connect = function(connectionList, opts, doneCb) { Blockchain.connect = function(connectionList, opts, doneCb) {
const self = this; const self = this;
const checkConnect = (next) => { const checkConnect = (next) => {
getAccounts(function(err, a) { this.blockchainConnector.getAccounts((err, _a) => {
if (err) { if (err) {
web3.setProvider(null); this.blockchainConnector.setProvider(null);
} }
return next(null, !err) return next(null, !err);
}); });
} };
const connectWeb3 = async (next) => { const connectWeb3 = async (next) => {
if (window.ethereum) { if (window.ethereum) {
try { try {
if (Blockchain.autoEnable) { if (Blockchain.autoEnable) {
await ethereum.enable(); await ethereum.enable();
this.blockchainConnector.setProvider(ethereum);
} }
web3.setProvider(ethereum);
return checkConnect(next); return checkConnect(next);
} catch (error) { } catch (error) {
return next(null, false); return next(null, false);
@ -44,17 +50,17 @@ Blockchain.connect = function(connectionList, opts, doneCb) {
} }
return next(null, false); return next(null, false);
} };
const connectWebsocket = (value, next) => { const connectWebsocket = (value, next) => {
web3.setProvider(new Web3.providers.WebsocketProvider(value)); this.blockchainConnector.setProvider(this.blockchainConnector.getNewProvider('WebsocketProvider', value));
checkConnect(next); checkConnect(next);
} };
const connectHttp = (value, next) => { const connectHttp = (value, next) => {
web3.setProvider(new Web3.providers.HttpProvider(value)); this.blockchainConnector.setProvider(this.blockchainConnector.getNewProvider('HttpProvider', value));
checkConnect(next); checkConnect(next);
} };
this.doFirst(function(cb) { this.doFirst(function(cb) {
reduce(connectionList, false, function(connected, value, next) { reduce(connectionList, false, function(connected, value, next) {
@ -62,43 +68,39 @@ Blockchain.connect = function(connectionList, opts, doneCb) {
return next(null, connected); return next(null, connected);
} }
if (typeof Web3 === 'undefined' || typeof web3 === 'undefined') {
return next(null, false);
}
if (value === '$WEB3') { if (value === '$WEB3') {
connectWeb3(next); connectWeb3(next);
} else if (value.indexOf('ws://') >= 0) { } else if (value.indexOf('ws://') >= 0) {
connectWebsocket(value, next) connectWebsocket(value, next);
} else { } else {
connectHttp(value, next) connectHttp(value, next);
} }
}, function(err, _connected) { }, function(_err, _connected) {
self.web3 = web3; self.blockchainConnector.getAccounts((err, accounts) => {
getAccounts(function(err, accounts) {
if (opts.warnAboutMetamask) { if (opts.warnAboutMetamask) {
if (web3.eth.currentProvider && web3.eth.currentProvider.isMetaMask) { const currentProv = self.blockchainConnector.getCurrentProvider();
if (currentProv && currentProv.isMetaMask) {
console.warn("%cNote: Embark has detected you are in the development environment and using Metamask, please make sure Metamask is connected to your local node", "font-size: 2em"); console.warn("%cNote: Embark has detected you are in the development environment and using Metamask, please make sure Metamask is connected to your local node", "font-size: 2em");
} }
} }
if (accounts) { if (accounts) {
web3.eth.defaultAccount = accounts[0]; self.blockchainConnector.setDefaultAccount(accounts[0]);
} }
cb(err); cb(err);
doneCb(err); doneCb(err);
}); });
}); });
}) });
}; };
Blockchain.enableEthereum = function() { Blockchain.enableEthereum = function() {
if (window.ethereum) { if (window.ethereum) {
return ethereum.enable().then((accounts) => { return ethereum.enable().then((accounts) => {
web3.setProvider(ethereum); this.blockchainConnector.setProvider(ethereum);
web3.eth.defaultAccount = accounts[0]; this.blockchainConnector.setDefaultAccount(accounts[0]);
contracts.forEach(contract => { contracts.forEach(contract => {
contract.options.from = web3.eth.defaultAccount; contract.options.from = this.blockchainConnector.getDefaultAccount();
}) });
return accounts; return accounts;
}); });
} }
@ -111,7 +113,7 @@ Blockchain.execWhenReady = function(cb) {
if (!this.list) { if (!this.list) {
this.list = []; this.list = [];
} }
this.list.push(cb) this.list.push(cb);
}; };
Blockchain.doFirst = function(todo) { Blockchain.doFirst = function(todo) {
@ -122,12 +124,11 @@ Blockchain.doFirst = function(todo) {
if (self.list) { if (self.list) {
self.list.map((x) => x.apply(x, [self.err, self.web3])); self.list.map((x) => x.apply(x, [self.err, self.web3]));
} }
}) });
}; };
let Contract = function (options) { let Contract = function(options) {
var self = this; var self = this;
var i, abiElement;
var ContractClass; var ContractClass;
this.abi = options.abi; this.abi = options.abi;
@ -136,185 +137,72 @@ let Contract = function (options) {
this.code = '0x' + options.code; this.code = '0x' + options.code;
this.web3 = options.web3; this.web3 = options.web3;
this.blockchainConnector = Blockchain.blockchainConnector;
Contract.checkWeb3.call(this); ContractClass = this.blockchainConnector.newContract({abi: this.abi, address: this.address});
contracts.push(ContractClass);
if (Contract.isNewWeb3(this.web3)) { ContractClass.options.data = this.code;
ContractClass = new this.web3.eth.Contract(this.abi, this.address); const from = this.from || self.blockchainConnector.getDefaultAccount() || this.web3.eth.defaultAccount;
contracts.push(ContractClass); if (from) {
ContractClass.options.data = this.code; ContractClass.options.from = from;
const from = this.from || this.web3.eth.defaultAccount
if (from) {
ContractClass.options.from = from
}
ContractClass.abi = ContractClass.options.abi;
ContractClass.address = this.address;
ContractClass.gas = this.gas;
let originalMethods = Object.keys(ContractClass);
Blockchain.execWhenReady(function(err, web3) {
if(!ContractClass.currentProvider){
ContractClass.setProvider(web3.currentProvider);
}
if (web3.eth.defaultAccount) {
ContractClass.options.from = web3.eth.defaultAccount;
}
});
ContractClass._jsonInterface.forEach((abi) => {
if (originalMethods.indexOf(abi.name) >= 0) {
console.log(abi.name + " is a reserved word and cannot be used as a contract method, property or event");
return;
}
if (!abi.inputs) {
return;
}
let numExpectedInputs = abi.inputs.length;
if (abi.type === 'function' && abi.constant) {
ContractClass[abi.name] = function () {
let options = {}, cb = null, args = Array.from(arguments || []).slice(0, numExpectedInputs);
if (typeof (arguments[numExpectedInputs]) === 'function') {
cb = arguments[numExpectedInputs];
} else if (typeof (arguments[numExpectedInputs]) === 'object') {
options = arguments[numExpectedInputs];
cb = arguments[numExpectedInputs + 1];
}
let ref = ContractClass.methods[abi.name];
let call = ref.apply(ref, ...arguments).call;
return call.apply(call, []);
};
} else if (abi.type === 'function') {
ContractClass[abi.name] = function () {
let options = {}, cb = null, args = Array.from(arguments || []).slice(0, numExpectedInputs);
if (typeof (arguments[numExpectedInputs]) === 'function') {
cb = arguments[numExpectedInputs];
} else if (typeof (arguments[numExpectedInputs]) === 'object') {
options = arguments[numExpectedInputs];
cb = arguments[numExpectedInputs + 1];
}
let ref = ContractClass.methods[abi.name];
let send = ref.apply(ref, args).send;
return send.apply(send, [options, cb]);
};
} else if (abi.type === 'event') {
ContractClass[abi.name] = function (options, cb) {
let ref = ContractClass.events[abi.name];
return ref.apply(ref, [options, cb]);
};
}
});
return ContractClass;
} else {
ContractClass = this.web3.eth.contract(this.abi);
this.eventList = [];
if (this.abi) {
for (i = 0; i < this.abi.length; i++) {
abiElement = this.abi[i];
if (abiElement.type === 'event') {
this.eventList.push(abiElement.name);
}
}
}
var messageEvents = function () {
this.cb = function () {
};
};
messageEvents.prototype.then = function (cb) {
this.cb = cb;
};
messageEvents.prototype.error = function (err) {
return err;
};
this._originalContractObject = ContractClass.at(this.address);
this._methods = Object.getOwnPropertyNames(this._originalContractObject).filter(function (p) {
// TODO: check for forbidden properties
if (self.eventList.indexOf(p) >= 0) {
self[p] = function () {
var promise = new messageEvents();
var args = Array.prototype.slice.call(arguments);
args.push(function (err, result) {
if (err) {
promise.error(err);
} else {
promise.cb(result);
}
});
self._originalContractObject[p].apply(self._originalContractObject[p], args);
return promise;
};
return true;
} else if (typeof self._originalContractObject[p] === 'function') {
self[p] = function (_args) {
var args = Array.prototype.slice.call(arguments);
var fn = self._originalContractObject[p];
var props = self.abi.find((x) => x.name == p);
var promise = new Promise(function (resolve, reject) {
args.push(function (err, transaction) {
promise.tx = transaction;
if (err) {
return reject(err);
}
var getConfirmation = function () {
self.web3.eth.getTransactionReceipt(transaction, function (err, receipt) {
if (err) {
return reject(err);
}
if (receipt !== null) {
return resolve(receipt);
}
setTimeout(getConfirmation, 1000);
});
};
if (typeof transaction !== "string" || props.constant) {
resolve(transaction);
} else {
getConfirmation();
}
});
fn.apply(fn, args);
});
return promise;
};
return true;
}
return false;
});
} }
}; ContractClass.abi = ContractClass.options.abi;
ContractClass.address = this.address;
ContractClass.gas = this.gas;
Contract.checkWeb3 = function () {}; let originalMethods = Object.keys(ContractClass);
Contract.isNewWeb3 = function (web3Obj) { Blockchain.execWhenReady(function(_err, _web3) {
var _web3 = web3Obj || (new Web3()); if (!ContractClass.currentProvider) {
if (typeof(_web3.version) === "string") { ContractClass.setProvider(self.blockchainConnector.getCurrentProvider() || self.web3.currentProvider);
return true;
} }
return parseInt(_web3.version.api.split('.')[0], 10) >= 1; ContractClass.options.from = self.blockchainConnector.getDefaultAccount() ||self.web3.eth.defaultAccount;
});
ContractClass._jsonInterface.forEach((abi) => {
if (originalMethods.indexOf(abi.name) >= 0) {
console.log(abi.name + " is a reserved word and cannot be used as a contract method, property or event");
return;
}
if (!abi.inputs) {
return;
}
let numExpectedInputs = abi.inputs.length;
if (abi.type === 'function' && abi.constant) {
ContractClass[abi.name] = function() {
let ref = ContractClass.methods[abi.name];
let call = ref.apply(ref, ...arguments).call;
return call.apply(call, []);
};
} else if (abi.type === 'function') {
ContractClass[abi.name] = function() {
let options = {}, cb = null, args = Array.from(arguments || []).slice(0, numExpectedInputs);
if (typeof (arguments[numExpectedInputs]) === 'function') {
cb = arguments[numExpectedInputs];
} else if (typeof (arguments[numExpectedInputs]) === 'object') {
options = arguments[numExpectedInputs];
cb = arguments[numExpectedInputs + 1];
}
let ref = ContractClass.methods[abi.name];
let send = ref.apply(ref, args).send;
return send.apply(send, [options, cb]);
};
} else if (abi.type === 'event') {
ContractClass[abi.name] = function(options, cb) {
let ref = ContractClass.events[abi.name];
return ref.apply(ref, [options, cb]);
};
}
});
return ContractClass;
}; };
Contract.prototype.deploy = function (args, _options) { Contract.prototype.deploy = function(args, _options) {
var self = this; var self = this;
var contractParams; var contractParams;
var options = _options || {}; var options = _options || {};
@ -322,15 +210,16 @@ Contract.prototype.deploy = function (args, _options) {
contractParams = args || []; contractParams = args || [];
contractParams.push({ contractParams.push({
from: this.web3.eth.accounts[0], from: this.blockchainConnector.getDefaultAccount() || this.web3.eth.accounts[0],
data: this.code, data: this.code,
gas: options.gas || 800000 gas: options.gas || 800000
}); });
var contractObject = this.web3.eth.contract(this.abi);
var promise = new Promise(function (resolve, reject) { const contractObject = this.blockchainConnector.newContract({abi: this.abi});
contractParams.push(function (err, transaction) {
return new Promise(function (resolve, reject) {
contractParams.push(function(err, transaction) {
if (err) { if (err) {
reject(err); reject(err);
} else if (transaction.address !== undefined) { } else if (transaction.address !== undefined) {
@ -344,30 +233,28 @@ Contract.prototype.deploy = function (args, _options) {
contractObject["new"].apply(contractObject, contractParams); contractObject["new"].apply(contractObject, contractParams);
}); });
return promise;
}; };
Contract.prototype.new = Contract.prototype.deploy; Contract.prototype.new = Contract.prototype.deploy;
Contract.prototype.at = function (address) { Contract.prototype.at = function(address) {
return new Contract({abi: this.abi, code: this.code, address: address}); return new Contract({abi: this.abi, code: this.code, address: address});
}; };
Contract.prototype.send = function (value, unit, _options) { Contract.prototype.send = function(value, unit, _options) {
var options, wei; let options, wei;
if (typeof unit === 'object') { if (typeof unit === 'object') {
options = unit; options = unit;
wei = value; wei = value;
} else { } else {
options = _options || {}; options = _options || {};
wei = this.web3.toWei(value, unit); wei = this.blockchainConnector.toWei(value, unit);
} }
options.to = this.address; options.to = this.address;
options.value = wei; options.value = wei;
this.web3.eth.sendTransaction(options); return this.blockchainConnector.send(options);
}; };
Blockchain.Contract = Contract; Blockchain.Contract = Contract;

View File

@ -1,16 +0,0 @@
import _EmbarkJS from './index';
var EmbarkJS = Object.assign({}, _EmbarkJS);
var _checkWeb3 = EmbarkJS.Contract.checkWeb3;
EmbarkJS.Contract.checkWeb3 = function () {
_checkWeb3.call(this);
if (!this.web3 && typeof (web3) !== 'undefined') {
this.web3 = web3;
} else if (!this.web3) {
this.web3 = window.web3;
}
};
export default EmbarkJS;

View File

@ -21,7 +21,8 @@ EmbarkJS.Utils = Utils;
EmbarkJS.Contract = function() { EmbarkJS.Contract = function() {
throw new Error('EmbarkJS.Contract is deprecated: please use EmbarkJS.Blockchain.Contract instead'); throw new Error('EmbarkJS.Contract is deprecated: please use EmbarkJS.Blockchain.Contract instead');
}; };
EmbarkJS.isNewWeb3 = function() {
EmbarkJS.isNewWeb3 = Blockchain.Contract.isNewWeb3; throw new Error('EmbarkJS.isNewWeb3 is deprecated: only Web3 1.0 is supported now');
};
export default EmbarkJS; export default EmbarkJS;

View File

@ -1,7 +1,7 @@
const path = require('path'); const path = require('path');
const standalone = { const standalone = {
entry: path.join(__dirname, 'dist/browser', 'browser.js'), entry: path.join(__dirname, 'dist/browser', 'index.js'),
mode: 'production', mode: 'production',
// optimization: { // optimization: {
// minimize: false // minimize: false
@ -13,7 +13,7 @@ const standalone = {
libraryTarget: 'umd', libraryTarget: 'umd',
libraryExport: 'default', libraryExport: 'default',
path: __dirname, path: __dirname,
umdNamedDefine: true, umdNamedDefine: true
}, },
target: 'web' target: 'web'
}; };