From 22bf8f7d5e959bdf7b2ae3af9c22643075a66a6c Mon Sep 17 00:00:00 2001 From: Jonathan Rainville Date: Thu, 26 Jul 2018 15:13:11 -0400 Subject: [PATCH] add registerSubDomain function --- src/names.js | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/names.js b/src/names.js index baad2ed..18f1031 100644 --- a/src/names.js +++ b/src/names.js @@ -1,6 +1,7 @@ let Names = {}; Names.Providers = {}; +Names.noProviderError = 'Name system provider not set; e.g EmbarkJS.Names.setProvider("ens")'; Names.registerProvider = function (providerName, obj) { Names.Providers[providerName] = obj; @@ -21,7 +22,7 @@ Names.setProvider = function (provider, options) { // resolve resolves a name into an identifier of some kind Names.resolve = function (name) { if (!this.currentNameSystems) { - throw new Error('Name system provider not set; e.g EmbarkJS.Names.setProvider("ens")'); + throw new Error(this.noProviderError); } return this.currentNameSystems.resolve(name); }; @@ -29,7 +30,7 @@ Names.resolve = function (name) { // the reverse of resolve, resolves using an identifier to get to a name Names.lookup = function (identifier) { if (!this.currentNameSystems) { - throw new Error('Name system provider not set; e.g EmbarkJS.Names.setProvider("ens")'); + throw new Error(this.noProviderError); } return this.currentNameSystems.lookup(identifier); }; @@ -38,15 +39,11 @@ Names.isAvailable = function () { return this.currentNameSystems.isAvailable(); }; -// To Implement - - -// register a name -Names.register = function(name, options) { +Names.registerSubDomain = function(name, address, callback) { if (!this.currentNameSystems) { - throw new Error('Name system provider not set; e.g EmbarkJS.Names.setProvider("ens")'); + throw new Error(this.noProviderError); } - return this.currentNameSystems.register(name, options); + return this.currentNameSystems.registerSubDomain(name, address, callback); }; export default Names;