codex-storage/nim-websock
1
0
Fork 0
mirror of https://github.com/codex-storage/nim-websock.git synced 2025-02-13 02:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: handle simultaneous closing properly (#112)

Browse Source 
Since we use readFrame instead of readMsg, we need to handle
it's possible exceptions. Closes #111
This commit is contained in:
Tanguy 2022-05-25 16:02:46 +02:00 committed by GitHub
parent 8927db93f6
commit 47b486b52f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
websock/session.nim
View File

@ -454,7 +454,11 @@ proc close*(
opcode = Opcode.Close) opcode = Opcode.Close)
# read frames until closed # read frames until closed
while ws.readyState != ReadyState.Closed: try:
discard await ws.readFrame() while ws.readyState != ReadyState.Closed:
discard await ws.readFrame()
except CatchableError as exc:
ws.readyState = ReadyState.Closed
await ws.stream.closeWait()
except CatchableError as exc: except CatchableError as exc:
trace "Exception closing", exc = exc.msg trace "Exception closing", exc = exc.msg