nim-libp2p/tests
Jacek Sieka f46bf0faa4
remove send lock (#334)
* remove send lock

When mplex receives data it will block until a reader has processed the
data. Thus, when a large message is received, such as a gossipsub
subscription table, all of mplex will be blocked until all reading is
finished.

However, if at the same time a `dial` to establish a gossipsub send
connection is ongoing, that `dial` will be blocked because mplex is no
longer reading data - specifically, it might indeed be the connection
that's processing the previous data that is waiting for a send
connection.

There are other problems with the current code:
* If an exception is raised, it is not necessarily raised for the same
connection as `p.sendConn`, so resetting `p.sendConn` in the exception
handling is wrong
* `p.isConnected` is checked before taking the lock - thus, if it
returns false, a new dial will be started. If a new task enters `send`
before dial is finished, it will also determine `p.isConnected` is
false, then get stuck on the lock - when the previous task finishes and
releases the lock, the new task will _also_ dial and thus reset
`p.sendConn` causing a leak.

* prefer existing connection

simplifies flow
2020-08-17 12:38:27 +02:00
..
pubsub remove send lock (#334) 2020-08-17 12:38:27 +02:00
helpers.nim reuse single RNG instance for all crypto key generation (#249) 2020-07-07 13:14:11 +02:00
nim.cfg Tests are now testing with --threads:on. 2019-11-06 13:01:16 +02:00
testbufferstream.nim consolidate reading in lpstream (#241) 2020-06-27 11:33:34 -06:00
testcid.nim Crypto utilities resultification (#150) 2020-05-18 07:25:55 +02:00
testconnection.nim Cleanup lpstream, Connection and BufferStream (#228) 2020-06-19 11:29:43 -06:00
testconnmngr.nim Connection manager (#277) 2020-07-17 09:36:48 -06:00
testcrypto.nim Audit curve fixes part2 (#298) 2020-08-04 18:19:26 +09:00
testdaemon.nim Peer resultification and defect only (#245) 2020-07-01 08:25:09 +02:00
testecnist.nim reuse single RNG instance for all crypto key generation (#249) 2020-07-07 13:14:11 +02:00
tested25519.nim reuse single RNG instance for all crypto key generation (#249) 2020-07-07 13:14:11 +02:00
testidentify.nim reuse single RNG instance for all crypto key generation (#249) 2020-07-07 13:14:11 +02:00
testinterop.nim Rework pubsub (#322) 2020-08-11 18:05:49 -06:00
testminasn1.nim Refactor minasn1 and fix security issues. (#323) 2020-08-11 16:58:51 -06:00
testminprotobuf.nim Minprotobuf refactoring 2 (#269) 2020-07-15 10:25:39 +02:00
testmplex.nim logging cleanups and small fixes (#331) 2020-08-15 21:50:31 +02:00
testmultiaddress.nim Less exceptions more results (#188) 2020-05-31 16:22:49 +02:00
testmultibase.nim Less exceptions more results (#188) 2020-05-31 16:22:49 +02:00
testmultihash.nim Crypto utilities resultification (#150) 2020-05-18 07:25:55 +02:00
testmultistream.nim pubsub timeouts tuning (#295) 2020-08-02 23:20:11 -06:00
testnative.nim Refactor minasn1 and fix security issues. (#323) 2020-08-11 16:58:51 -06:00
testnoise.nim Channel timeout (#278) 2020-07-17 12:44:41 -06:00
testpeer.nim Fix #266. (#270) 2020-07-15 10:24:04 +02:00
testpeerinfo.nim peer hooks -> events (#320) 2020-08-08 08:52:20 +02:00
testpkifilter.nim Public key infrastructure filters. (#272) 2020-07-21 14:10:21 -06:00
testrsa.nim Fix #266. (#270) 2020-07-15 10:24:04 +02:00
testsecp256k1.nim reuse single RNG instance for all crypto key generation (#249) 2020-07-07 13:14:11 +02:00
teststreamseq.nim remove readLoop in secure protocols (#162) 2020-05-07 14:37:46 -06:00
testswitch.nim Rework pubsub (#322) 2020-08-11 18:05:49 -06:00
testtransport.nim consolidate reading in lpstream (#241) 2020-06-27 11:33:34 -06:00
testvarint.nim Less exceptions more results (#188) 2020-05-31 16:22:49 +02:00