codex-storage
/
nim-libp2p
mirror of https://github.com/codex-storage/nim-libp2p.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't modify iterables while iterating them (#219) 

* don't modify iterables while iterating

* assert handlers to properly close connections
This commit is contained in:
Dmitriy Ryajov 2020-06-15 12:30:09 -06:00 committed by GitHub
parent 9cd47fe816
commit 7cb6c81159
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libp2p/muxers/mplex/mplex.nim
View File

@ -118,6 +118,7 @@ method handle*(m: Mplex) {.async, gcsafe.} =
# doAssert(stream.closed, "connection not closed by handler!") # doAssert(stream.closed, "connection not closed by handler!")
except CatchableError as exc: except CatchableError as exc:
trace "exception in stream handler", exc = exc.msg trace "exception in stream handler", exc = exc.msg
doAssert(stream.closed, "stream not closed by protocol handler")
finally: finally:
m.conns.keepItIf(it != stream) m.conns.keepItIf(it != stream)
m.handlerFuts.keepItIf(it != fut) m.handlerFuts.keepItIf(it != fut)

2
libp2p/protocols/pubsub/gossipsub.nim
View File

@ -215,7 +215,7 @@ proc heartbeat(g: GossipSub) {.async.} =
await g.heartbeatLock.acquire() await g.heartbeatLock.acquire()
trace "running heartbeat" trace "running heartbeat"
for t in g.topics.keys: for t in toSeq(g.topics.keys):
await g.rebalanceMesh(t) await g.rebalanceMesh(t)
await g.dropFanoutPeers() await g.dropFanoutPeers()