From 39fb9ed2dee8bff35c113d25f5488f5d953f4a06 Mon Sep 17 00:00:00 2001 From: cheatfate Date: Mon, 25 Feb 2019 11:06:50 +0200 Subject: [PATCH] Fix fail verification tests. --- tests/testecnist.nim | 27 ++++++++++++++++++--------- tests/testrsa.nim | 12 ++++++++---- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/tests/testecnist.nim b/tests/testecnist.nim index 6735bf1..f803d4d 100644 --- a/tests/testecnist.nim +++ b/tests/testecnist.nim @@ -290,7 +290,8 @@ suite "EC NIST-P256/384/521 test suite": check: checksig == expectsig checksig.verify(SignatureMessages[i], checkpk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(SignatureMessages[i], checkpk) == false test "[secp256r1] ECDSA non-deterministic test vectors": @@ -302,7 +303,8 @@ suite "EC NIST-P256/384/521 test suite": var message = NDMessages[i] var checksig = EcSignature.init(stripSpaces(NDSignatures[i])) check checksig.verify(message, pk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(message, pk) == false test "[secp256r1] Generate/Sign/Serialize/Deserialize/Verify test": @@ -317,7 +319,8 @@ suite "EC NIST-P256/384/521 test suite": var pubkey = EcPublicKey.init(serpk) var csig = EcSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[secp384r1] Private key serialize/deserialize test": @@ -379,7 +382,8 @@ suite "EC NIST-P256/384/521 test suite": check: checksig == expectsig checksig.verify(SignatureMessages[i], checkpk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(SignatureMessages[i], checkpk) == false test "[secp384r1] ECDSA non-deterministic test vectors": @@ -391,7 +395,8 @@ suite "EC NIST-P256/384/521 test suite": var message = NDMessages[i] var checksig = EcSignature.init(stripSpaces(NDSignatures[i])) check checksig.verify(message, pk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(message, pk) == false test "[secp384r1] Generate/Sign/Serialize/Deserialize/Verify test": @@ -406,7 +411,8 @@ suite "EC NIST-P256/384/521 test suite": var pubkey = EcPublicKey.init(serpk) var csig = EcSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[secp521r1] Private key serialize/deserialize test": @@ -468,7 +474,8 @@ suite "EC NIST-P256/384/521 test suite": check: checksig == expectsig checksig.verify(SignatureMessages[i], checkpk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(SignatureMessages[i], checkpk) == false test "[secp521r1] ECDSA non-deterministic test vectors": @@ -480,7 +487,8 @@ suite "EC NIST-P256/384/521 test suite": var message = NDMessages[i] var checksig = EcSignature.init(stripSpaces(NDSignatures[i])) check checksig.verify(message, pk) == true - checksig.buffer[len(checksig.buffer) - 1] = 0x80'u8 + let error = len(checksig.buffer) - 1 + checksig.buffer[error] = not(checksig.buffer[error]) check checksig.verify(message, pk) == false test "[secp521r1] Generate/Sign/Serialize/Deserialize/Verify test": @@ -495,5 +503,6 @@ suite "EC NIST-P256/384/521 test suite": var pubkey = EcPublicKey.init(serpk) var csig = EcSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false diff --git a/tests/testrsa.nim b/tests/testrsa.nim index f281a06..52e6187 100644 --- a/tests/testrsa.nim +++ b/tests/testrsa.nim @@ -422,7 +422,8 @@ suite "RSA 512/1024/2048/4096 test suite": var pubkey = RsaPublicKey.init(serpk) var csig = RsaSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[rsa1024] Generate/Sign/Serialize/Deserialize/Verify test": @@ -437,7 +438,8 @@ suite "RSA 512/1024/2048/4096 test suite": var pubkey = RsaPublicKey.init(serpk) var csig = RsaSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[rsa2048] Generate/Sign/Serialize/Deserialize/Verify test": @@ -451,7 +453,8 @@ suite "RSA 512/1024/2048/4096 test suite": var pubkey = RsaPublicKey.init(serpk) var csig = RsaSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[rsa4096] Generate/Sign/Serialize/Deserialize/Verify test": @@ -466,7 +469,8 @@ suite "RSA 512/1024/2048/4096 test suite": var pubkey = RsaPublicKey.init(serpk) var csig = RsaSignature.init(sersig) check csig.verify(message, pubkey) == true - csig.buffer[len(csig.buffer) - 1] = 0x80'u8 + let error = len(csig.buffer) - 1 + csig.buffer[error] = not(csig.buffer[error]) check csig.verify(message, pubkey) == false test "[rsa512] Test vectors":