codex-storage
/
nim-libp2p
mirror of https://github.com/codex-storage/nim-libp2p.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add TODO to explain why half closed tests failed

This commit is contained in:
Dmitriy Ryajov 2020-02-12 10:00:50 -05:00
parent 7f8eb0272e
commit 30a496de5e
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/testmplex.nim
View File

@ -357,6 +357,12 @@ suite "Mplex":
expect LPStreamEOFError: expect LPStreamEOFError:
waitFor(testClosedForWrite()) waitFor(testClosedForWrite())
# TODO: this locks up after removing sleepAsync as a
# synchronization mechanism in mplex. I believe this
# is related to how chronos schedules callbacks in select,
# which effectively puts to infinite sleep when there
# are no more callbacks, so essentially this sequence of
# reads isn't possible with the current chronos.
# test "half closed - channel should close for read by remote": # test "half closed - channel should close for read by remote":
# proc testClosedForRead(): Future[void] {.async.} = # proc testClosedForRead(): Future[void] {.async.} =
# proc writeHandler(data: seq[byte]) {.async, gcsafe.} = discard # proc writeHandler(data: seq[byte]) {.async, gcsafe.} = discard