fix: cleaning up based on jangko review

This commit is contained in:
Dmitriy Ryajov 2019-08-31 13:07:00 -06:00
parent db1aad3df0
commit 18b9765525
1 changed files with 6 additions and 7 deletions

View File

@ -31,6 +31,7 @@ type
observedAddr*: MultiAddress observedAddr*: MultiAddress
protoVersion*: string protoVersion*: string
agentVersion*: string agentVersion*: string
protos*: seq[string]
Identify* = ref object of LPProtocol Identify* = ref object of LPProtocol
@ -41,8 +42,8 @@ proc encodeMsg*(peerInfo: PeerInfo, observedAddrs: Multiaddress): ProtoBuffer =
for ma in peerInfo.addrs: for ma in peerInfo.addrs:
result.write(initProtoField(2, ma.data.buffer)) result.write(initProtoField(2, ma.data.buffer))
for item in peerInfo.protocols: for proto in peerInfo.protocols:
result.write(initProtoField(3, item)) result.write(initProtoField(3, proto))
result.write(initProtoField(4, observedAddrs.data.buffer)) result.write(initProtoField(4, observedAddrs.data.buffer))
@ -56,9 +57,7 @@ proc encodeMsg*(peerInfo: PeerInfo, observedAddrs: Multiaddress): ProtoBuffer =
proc decodeMsg*(buf: seq[byte]): IdentifyInfo = proc decodeMsg*(buf: seq[byte]): IdentifyInfo =
var pb = initProtoBuffer(buf) var pb = initProtoBuffer(buf)
var pubKey: PublicKey discard pb.getValue(1, result.pubKey)
if pb.getValue(1, pubKey) > -1:
result.pubKey = pubKey
result.addrs = newSeq[MultiAddress]() result.addrs = newSeq[MultiAddress]()
var address = newSeq[byte]() var address = newSeq[byte]()
@ -69,9 +68,9 @@ proc decodeMsg*(buf: seq[byte]): IdentifyInfo =
address.setLen(0) address.setLen(0)
var proto = "" var proto = ""
var protos: seq[string] = newSeq[string]() # var protos: seq[string] = newSeq[string]()
while pb.getString(3, proto) > 0: while pb.getString(3, proto) > 0:
protos.add(proto) result.protos.add(proto)
proto = "" # TODO: do i need to clear it up? proto = "" # TODO: do i need to clear it up?
var observableAddr = newSeq[byte]() var observableAddr = newSeq[byte]()