codex-storage/nim-codex
1
0
Fork 0
mirror of https://github.com/codex-storage/nim-codex.git synced 2025-02-08 02:55:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename metrics to follow codex conventions

Browse Source
This commit is contained in:
gmega 2023-11-07 09:09:45 -03:00
parent c809af7dc7
commit b50469f6cc
No known key found for this signature in database
GPG Key ID: FFD8DAF00660270F
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
codex/utils/asyncprofiler/metricscollector.nim
View File

@ -73,13 +73,13 @@ when defined(metrics):
prometheusMetrics[labelValues] = procMetrics
addLabeledMetric(
"total_exec_time", metrics.totalExecTime, prometheusMetrics)
"chronos_exec_time_total", metrics.totalExecTime, prometheusMetrics)
addLabeledMetric(
"total_run_time", metrics.totalRunTime, prometheusMetrics)
"chronos_run_time_total", metrics.totalRunTime, prometheusMetrics)
addLabeledMetric(
"total_wall_time", metrics.totalWallTime, prometheusMetrics)
"chronos_wall_time_total", metrics.totalWallTime, prometheusMetrics)
addLabeledMetric(
"max_single_exec_time", metrics.maxSingleTime, prometheusMetrics)
"chronos_single_exec_time_max", metrics.maxSingleTime, prometheusMetrics)
proc collectOutlierMetrics(
self: AsyncProfilerInfo,
@ -101,13 +101,13 @@ when defined(metrics):
largestExecTime = metric.totalExecTime
prometheusMetrics[@[]].add(Metric(
name: "largest_total_exec_time",
name: "chronos_largest_exec_time_total",
value: largestExecTime.metricValue(),
timestamp: timestampMillis,
))
prometheusMetrics[@[]].add(Metric(
name: "largest_max_exec_time",
name: "chronos_largest_exec_time_max",
value: largestMaxExecTime.metricValue(),
timestamp: timestampMillis,
))

12
tests/codex/utils/asyncprofiler/testmetricscollector.nim
View File

@ -59,8 +59,8 @@ checksuite "asyncprofiler metrics collector":
perfSampler = proc (): MetricsSummary = sample
)
check collector.valueByName("largest_total_exec_time") == 91660
check collector.valueByName("largest_max_exec_time") == 81660
check collector.valueByName("chronos_largest_exec_time_total") == 91660
check collector.valueByName("chronos_largest_exec_time_max") == 81660
test "should create labeled series for the k slowest procs in terms of totalExecTime":
var registry = newRegistry()
@ -72,14 +72,14 @@ checksuite "asyncprofiler metrics collector":
perfSampler = proc (): MetricsSummary = sample
)
check collector.valueByName("total_exec_time",
check collector.valueByName("chronos_exec_time_total",
labelValues = @["start", "discovery.nim", "192"]) == 91660
check collector.valueByName("total_exec_time",
check collector.valueByName("chronos_exec_time_total",
labelValues = @["start", "discovery.nim", "174"]) == 90062
check collector.valueByName("total_exec_time",
check collector.valueByName("chronos_exec_time_total",
labelValues = @["update", "sqliteds.nim", "107"]) == 60645
# This is out of the top-k slowest, so should not have been recorded.
expect system.KeyError:
discard collector.valueByName("total_exec_time",
discard collector.valueByName("chronos_exec_time_total",
labelValues = @["query", "manager.nim", "323"])