handle exceptions gracefuly in rest api (#617)

codex/rest/api.nim

@@ -160,18 +160,22 @@ proc initSalesApi(node: CodexNodeRef, router: var RestRouter) =
     MethodGet,
     "/api/codex/v1/sales/slots") do () -> RestApiResponse:
       ## Returns active slots for the host
-
+      try:
         without contracts =? node.contracts.host:
           return RestApiResponse.error(Http503, "Sales unavailable")
 
         let json = %(await contracts.sales.mySlots())
         return RestApiResponse.response($json, contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   router.api(
     MethodGet,
     "/api/codex/v1/sales/availability") do () -> RestApiResponse:
       ## Returns storage that is for sale
 
+      try:
         without contracts =? node.contracts.host:
           return RestApiResponse.error(Http503, "Sales unavailable")
 
@@ -180,6 +184,9 @@ proc initSalesApi(node: CodexNodeRef, router: var RestRouter) =
 
         let json = %avails
         return RestApiResponse.response($json, contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   router.rawApi(
     MethodPost,
@@ -191,6 +198,7 @@ proc initSalesApi(node: CodexNodeRef, router: var RestRouter) =
       ## minPrice       - minimum price to be paid (in amount of tokens)
       ## maxCollateral  - maximum collateral user is willing to pay per filled Slot (in amount of tokens)
 
+      try:
         without contracts =? node.contracts.host:
           return RestApiResponse.error(Http503, "Sales unavailable")
 
@@ -215,6 +223,9 @@ proc initSalesApi(node: CodexNodeRef, router: var RestRouter) =
 
         return RestApiResponse.response(availability.toJson,
                                         contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
 proc initPurchasingApi(node: CodexNodeRef, router: var RestRouter) =
   router.rawApi(
@@ -231,6 +242,7 @@ proc initPurchasingApi(node: CodexNodeRef, router: var RestRouter) =
       ## tolerance        - allowed number of nodes that can be lost before pronouncing the content lost
       ## colateral        - requested collateral from hosts when they fill slot
 
+      try:
         without cid =? cid.tryGet.catch, error:
           return RestApiResponse.error(Http400, error.msg)
 
@@ -255,12 +267,16 @@ proc initPurchasingApi(node: CodexNodeRef, router: var RestRouter) =
           return RestApiResponse.error(Http500, error.msg)
 
         return RestApiResponse.response(purchaseId.toHex)
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   router.api(
     MethodGet,
     "/api/codex/v1/storage/purchases/{id}") do (
       id: PurchaseId) -> RestApiResponse:
 
+      try:
         without contracts =? node.contracts.client:
           return RestApiResponse.error(Http503, "Purchasing unavailable")
 
@@ -278,15 +294,22 @@ proc initPurchasingApi(node: CodexNodeRef, router: var RestRouter) =
         )
 
         return RestApiResponse.response($json, contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   router.api(
     MethodGet,
     "/api/codex/v1/storage/purchases") do () -> RestApiResponse:
+      try:
         without contracts =? node.contracts.client:
           return RestApiResponse.error(Http503, "Purchasing unavailable")
 
         let purchaseIds = contracts.purchasing.getPurchaseIds()
         return RestApiResponse.response($ %purchaseIds, contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
 proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
   router.api(
@@ -295,6 +318,7 @@ proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
       ## Print rudimentary node information
       ##
 
+      try:
         let table = RestRoutingTable.init(node.discovery.protocol.routingTable)
 
         let
@@ -316,6 +340,9 @@ proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
           }
 
         return RestApiResponse.response($json, contentType="application/json")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   router.api(
     MethodPost,
@@ -328,6 +355,7 @@ proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
       ## `level` - chronicles log level
       ##
 
+      try:
         without res =? level and level =? res:
           return RestApiResponse.error(Http400, "Missing log level")
 
@@ -338,12 +366,16 @@ proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
           return RestApiResponse.error(Http500, exc.msg)
 
         return RestApiResponse.response("")
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
   when codex_enable_api_debug_peers:
     router.api(
       MethodGet,
       "/api/codex/v1/debug/peer/{peerId}") do (peerId: PeerId) -> RestApiResponse:
 
+      try:
         trace "debug/peer start"
         without peerRecord =? (await node.findPeer(peerId.get())):
           trace "debug/peer peer not found!"
@@ -354,6 +386,9 @@ proc initDebugApi(node: CodexNodeRef, conf: CodexConf, router: var RestRouter) =
         let json = %RestPeerRecord.init(peerRecord)
         trace "debug/peer returning peer record"
         return RestApiResponse.response($json)
+      except CatchableError as exc:
+        trace "Excepting processing request", exc = exc.msg
+        return RestApiResponse.error(Http500)
 
 proc initRestApi*(node: CodexNodeRef, conf: CodexConf): RestRouter =
   var router = RestRouter.init(validate)
@@ -397,6 +432,6 @@ proc initRestApi*(node: CodexNodeRef, conf: CodexConf): RestRouter =
       except DialFailedError:
         return RestApiResponse.error(Http400, "Unable to dial peer")
       except CatchableError:
-        return RestApiResponse.error(Http400, "Unknown error dialling peer")
+        return RestApiResponse.error(Http500, "Unknown error dialling peer")
 
   return router