codex-storage/nim-codex-dht
1
0
Fork 0
mirror of https://github.com/codex-storage/nim-codex-dht.git synced 2025-01-24 02:49:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #93 from codex-storage/fix-FindNodeResultLimit

Browse Source 
fix returning too many nodes when FindNodeResultLimit!=BUCKET_SIZE
This commit is contained in:
Csaba Kiraly 2024-10-01 14:51:33 +02:00 committed by GitHub
commit 936a5ec6fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codexdht/private/eth/p2p/discoveryv5/protocol.nim
View File

@ -338,7 +338,7 @@ proc handleFindNode(d: Protocol, fromId: NodeId, fromAddr: Address,
# TODO: Still deduplicate also?
if fn.distances.all(proc (x: uint16): bool = return x <= 256):
d.sendNodes(fromId, fromAddr, reqId,
d.routingTable.neighboursAtDistances(fn.distances, seenOnly = true))
d.routingTable.neighboursAtDistances(fn.distances, seenOnly = true, k = FindNodeResultLimit))
else:
# At least one invalid distance, but the polite node we are, still respond
# with empty nodes.
@ -347,7 +347,7 @@ proc handleFindNode(d: Protocol, fromId: NodeId, fromAddr: Address,
proc handleFindNodeFast(d: Protocol, fromId: NodeId, fromAddr: Address,
fnf: FindNodeFastMessage, reqId: RequestId) =
d.sendNodes(fromId, fromAddr, reqId,
d.routingTable.neighbours(fnf.target, seenOnly = true))
d.routingTable.neighbours(fnf.target, seenOnly = true, k = FindNodeResultLimit))
# TODO: if known, maybe we should add exact target even if not yet "seen"
proc handleTalkReq(d: Protocol, fromId: NodeId, fromAddr: Address,