Calum Lind
c7fd8f5116
[Lint] Fix redefining filename in script
2016-05-09 20:10:51 +01:00
Calum Lind
618d2f9f58
[Lint] Enable pylint 'bad-continuation' and fix issues
...
There is some discrepency between pep8 and pylint for line
continuation (https://github.com/PyCQA/pylint/issues/747 ) but
with some minor layout changes both can pass and code looks fine,
if not better in places.
2016-05-09 20:10:51 +01:00
Calum Lind
807d7a7aaf
[Lint] Fix pylint msg for rencode
2016-05-09 19:52:47 +01:00
Calum Lind
416fb5e1e3
[ #2832 ] [UI] Skip blank lines in auth file
2016-05-09 16:39:10 +01:00
bendikro
1fb9960168
[Base] Updated fix for missing trace with new twisted logger
...
Includes a commented out test to replicate the issue.
2016-05-09 13:57:54 +01:00
Calum Lind
919e41f55e
[Lint] [GTKUI] Apply isort fix for fixed placement imports
...
This solves the requirement for deluge imports to be placed after
installing the twisted reactor.
2016-05-09 09:44:30 +01:00
Calum Lind
616523c732
[rencode] Update module to v1.0.4
2016-05-09 09:27:50 +01:00
bendikro
bb0e699619
[UI] Add tests for ui_entry
2016-05-08 12:00:44 +01:00
Calum Lind
d5294d5733
[Tests] Fix json_api AlreadyCancelled watchdog error
2016-05-08 10:36:44 +01:00
Calum Lind
3769d99532
[GTKUI] Fix silly typo
2016-05-07 00:52:47 +01:00
bendikro
c7b272561e
[ #2827 ] [GTKUI] Fix issue with loading GTKUI columns state
...
commit 1a2ff9b089
introduced a bug when loading GTKUI
column states due to changing ListViewColumnState class type.
Fixed by reverting ListViewColumnState to old style class
2016-05-06 22:59:51 +01:00
Calum Lind
21789e0692
[ #2813 ] [GTKUI] Fix connection manager showing daemon offline in Windows
...
The daemon status is not retrieved when showing the connection manager at
startup on Windows and shows it as offline.
This commit restores the removal of simulate call in commit 058b0e41d2
but applies it only to Windows OS as there were no problems in Ubuntu testing.
It would suggest then that the issue is isolated to PortableGtkReactor
but the exact cause of the problem is still unknown.
2016-05-06 22:30:20 +01:00
bendikro
1a2ff9b089
[Lint] Fix and remove old-style-class from ignore warnings
2016-05-06 12:44:45 +01:00
bendikro
3ec8dc6858
[Lint] Remove warnings from .pylintrc
...
Remove warnings from ignore list in .pylintrc:
* super-on-old-class
* pointless-except
* non-parent-init-called
2016-05-06 12:44:45 +01:00
bendikro
9be1bd523a
[Tests] Cancel watchdog deferreds on test completion
2016-05-06 12:44:45 +01:00
bendikro
1f191c3ce1
[Base] Fix incorrect use of defer.fail in component
2016-05-06 12:44:45 +01:00
bendikro
91ed621ec8
[UI] Changed ui command description and help
2016-05-06 12:44:45 +01:00
bendikro
6adbd14bf8
[Base] Add custom log observer to handle twisted errors
...
For some reason errors are logged by twisted as
'Unhandled error in Deferred', but without a following
stacktrace. This can happen in a deferred callback that e.g.
raises an ImportError. Without an excplicit error handler for a
deferred to log such errors, finding the error can be very tricky.
Fix this by using a custom twisted.python.log.PythonLoggingObserver,
PythonLoggingObserver, that also logs the traceback in addition to
the error message.
2016-05-06 12:44:45 +01:00
bendikro
5826446509
[Lint] Fix pylint signature-differs warning
2016-05-06 12:44:45 +01:00
bendikro
84d2d20e13
[Web] Pylint fix for WebUtils
2016-04-29 23:23:23 +01:00
Calum Lind
3ed4c8d636
[Lint] Add pylint to tox run
2016-04-29 23:23:18 +01:00
Calum Lind
c15931e6f6
[Tests] Rename pylintrc and ignore .tox dir
2016-04-28 23:34:18 +01:00
bendikro
7c20ed777d
[Core] Save fastresume file on separate thread
...
To avoid blocking twisted main thread, defer file saving task to
separate thread with deferToThread.
Only queue resume data save task on shutdown
2016-04-28 23:14:29 +01:00
Calum Lind
5d0359331b
[ #2821 ] [UI] Fix missing parameter in baseargs init
2016-04-28 22:42:59 +01:00
Calum Lind
b255fc40af
[WebUI] Remove openssl check as already a requirement
2016-04-28 11:10:09 +01:00
Calum Lind
7b523af05b
[ #2819 ] [WebUI] Handle CannotListenError for second instance
2016-04-28 11:09:53 +01:00
Calum Lind
bd65abd3b4
[UI] [Core] Combine common process options into baseargparser
2016-04-28 11:09:53 +01:00
Calum Lind
b4dd90ba2b
Cleanup code in web and deamon entries to match
2016-04-28 11:09:52 +01:00
Calum Lind
c274d5114c
[ #2818 ] [WebUI] Fix AttributeError starting WebUI on windows
2016-04-28 11:09:52 +01:00
Calum Lind
c821cdd9c7
[UI] Fix unable to use uppercase log level
2016-04-28 11:09:52 +01:00
Calum Lind
69871506e1
Improve order of args and wording of '--help' text
2016-04-28 11:09:39 +01:00
Calum Lind
a99e29642c
[UI] Restore short arg for version '-V' (deprecate '-v')
2016-04-28 11:09:26 +01:00
Calum Lind
acdc19df1d
Add translation markup to '--help' options
2016-04-28 11:07:26 +01:00
Calum Lind
2bad04848c
[WebUI] Update gettext.js
2016-04-25 15:41:47 +01:00
Calum Lind
bf3d6ae24b
[WebUI] Add refresh dialog for language change
2016-04-25 15:35:52 +01:00
Calum Lind
2984e2dc5d
[WebUI] Fix Interface page not saving with OK button
2016-04-25 15:35:21 +01:00
Calum Lind
3b23f69786
[WebUI] Use Apply button to change password
2016-04-25 13:26:59 +01:00
Calum Lind
9fbc63e6fb
[WebUI] Tidy Interface page layout
2016-04-25 13:26:59 +01:00
Calum Lind
cb158ca866
[Core] Add missing warn_msg arg to set_dummy_trans()
2016-04-25 13:26:59 +01:00
bendikro
857e2fd46e
[ #1959 ] [WebUI] Allow user selectable GUI language
2016-04-25 13:26:58 +01:00
bendikro
74f2f45fc0
[WebUI] Fix to gen_web_gettext
2016-04-25 13:26:58 +01:00
bendikro
b76d208212
[UI] Added missing languages to languages.py
2016-04-25 13:26:58 +01:00
bendikro
dea43da4d2
[UI] [Daemon] Re-add --fork option
2016-04-24 22:39:16 +01:00
Calum Lind
d32796eab0
[WebUI] Reword doctring and update gettext.js
2016-04-23 23:13:11 +01:00
Calum Lind
1a79d7c255
[WebUI] Remove unneeded translation markup
2016-04-23 22:40:17 +01:00
Calum Lind
1afea60c6f
[UI] Indent subsequent lines in argparse help
2016-04-23 22:10:29 +01:00
Calum Lind
a49b459a59
[UI] Remove old twisted DeprecationWarning code
2016-04-23 22:10:29 +01:00
Calum Lind
9a051b6979
[UI] Enable translation of argparse help strings
2016-04-23 22:10:29 +01:00
bendikro
64ac5fdf73
[ #2677 ] [Web] With --base option set, serve locally on new base path
...
When specifying the --base option to work with reverse proxy
the WebUI is no longer accessible locally since it listens
on the server root, but serves on the path specified to work
for the reverse proxy.
Change this to also handle local requests to the base path
such that the WebUI will be available both for the reverse proxy
as well as locally on the interface/port which the twisted sever
listens on.
2016-04-22 23:04:19 +01:00
bendikro
ec366c840c
[Core] Fix unnecessary delay when starting components
2016-04-21 14:44:48 +02:00