Calum Lind
441861786b
[GTKUI] Add decode_string to column name comparison
...
* Strings from GTK are returned utf8 encoded so require decoding if
comparing with unicode strings passed around in python code.
2016-11-11 22:22:50 +00:00
Calum Lind
0cdf0230e9
[GTKUI] Refactor gtk imports and code
...
* Where possible use 'from gtk import ...', i.e. if repeated often or under 10 individual imports.
* Remove osx_check to not show svg. It's only an issue on Windows so should work fine...
* Rearrange and deduplicate code into d.u.g.common for getting pixbuf from files.
* Use 'from gtk.gdk import...' to make it cleaner to apply GTK3 changes in future.
* Move generic icon code from torrent_data_funcs to common.
* Fix pylint import warnings and add WindowsError to pylintrc file.
2016-11-11 22:21:51 +00:00
Calum Lind
c8e6a4476d
[GTKUI] Another update of methods to latest GTK2 API 2.24
...
* These updates make the code more compatible with GTK3
2016-11-11 14:08:25 +00:00
Calum Lind
ccfe6b3c80
[GTKUI] Add MainWindow.get_window() and replace window attr usage
...
* In GTK3 the use of `window` attribute is no longer valid so need to
use get_window(). This updates MainWindow to follow the same convention.
2016-11-11 14:08:25 +00:00
Calum Lind
86549eb3ee
[GTKUI] Cleanup references to MainWindow
2016-11-11 14:08:25 +00:00
Calum Lind
243004c551
[GTKUI] Remove About dialog unneeded url_hook
...
* This is removed in Gtk3 and clicking url in Gtk2 still works.
2016-11-11 14:08:25 +00:00
Calum Lind
8ba8aec277
[GTKUI] Listview use lambda func for set_default_sort_func
...
* gi complains about `None` value being passed to set_default_sort_func
so for compatibility use lamba func that does nothing.
There is an unanswered question on SO about how to set the default func to None in gi:
http://stackoverflow.com/questions/20940324/how-to-remove-the-default-sort-function-from-a-treesortable
2016-11-11 14:08:25 +00:00
Calum Lind
a5b07aa4ef
[GTKUI] Update methods to latest GTK2 API 2.24
2016-11-11 14:08:24 +00:00
Calum Lind
c619674cf9
[GTKUI] Import gobject module names directly
2016-11-11 14:08:24 +00:00
Calum Lind
52d591c83b
[GTKUI] Remove unneeded pygtk requires check
2016-11-11 14:08:24 +00:00
Calum Lind
4313974f07
[Lang] Add fallback dll for Windows libintl
2016-11-11 14:08:24 +00:00
Calum Lind
bde13515e6
[Common] Only attempt dbus import on non-Win/OSX
2016-11-11 14:08:24 +00:00
Calum Lind
93ab2445a1
[GTKUI] Update version string in ui files
2016-11-09 15:01:44 +00:00
Calum Lind
eea3cb0553
[GTKUI] Tweak spacing of main window tabs
2016-11-08 21:09:01 +00:00
Calum Lind
6bd3c6fa88
[ #2922 ] [Core] Fix using incorrect type for peer_tos in lt 1.1
2016-11-08 20:25:16 +00:00
Calum Lind
b6e2ec3a3c
[Core] Remove redundant utf8 encoding
...
* Should only be encoding in config.py and this is already occurs.
2016-11-08 20:16:59 +00:00
Calum Lind
bbe9de9463
[Core] Disable apply_settings for enc policy until fix can be found
2016-11-06 00:14:07 +00:00
Calum Lind
2bdbcf9a39
[ #2922 ] Fix interfaces and outgoing ports for lt 1.1
2016-11-05 23:30:01 +00:00
Calum Lind
fd80ed75fe
[ #2922 ] Fix proxy settings and torrent status for lt 1.1
2016-11-05 15:49:39 +00:00
Calum Lind
0890cc1a33
[ #2922 ] Fix session.apply_sessings alert_mask
2016-11-05 11:30:31 +00:00
Calum Lind
e31acfc31c
[GTKUI] Restart application when switching modes
2016-11-04 23:54:46 +00:00
Calum Lind
d0d070aaf0
[Lint] Fix flake8
2016-11-04 23:54:23 +00:00
Calum Lind
1e41891943
[Oops] Bugfix for previous commit: e37c817
2016-11-04 18:07:59 +00:00
Calum Lind
e37c817151
[Lint] Refactor flake8 noqa's and add msg numbers
...
From pep8-naming:
* N802: function name should be lowercase
* N803: argument name should be lowercase
2016-11-04 18:03:21 +00:00
Calum Lind
af6b277d28
[Lint] Add flake8-quotes to tox and fix bad quotes
2016-11-04 00:10:23 +00:00
Calum Lind
3a2ff0c188
[Lint] Convert all python double quotes to single quotes
...
* A rather disruptive change but for a few reasons such as easier to read,
easier type, keep consistent and javascript code uses single quotes.
* There are a few exceptions for the automated process:
* Any double quotes in comments
* Triple double quotes for docstrings
* Strings containing single quotes are left e.g. "they're"
* To deal with merge conflicts from feature branches it is best to follow
these steps for each commit:
* Create a patch: `git format-patch -1 <sha1>`
* Edit the patch and replace double quotes with single except those in
comments or strings containing an unescaped apostrophe.
* Check the patch `git apply --check <patchfile>` and fix any remaining
issues if it outputs an error.
* Apply the patch `git am < <patchfile>`
2016-11-03 21:45:45 +00:00
Calum Lind
d4a8a38586
[Core] Refactor out duplicate prefsmgr log lines
2016-11-03 12:05:55 +00:00
Calum Lind
a87ce825ad
[Core] Remove old geoip.dat code and fix log line
2016-11-03 11:37:20 +00:00
Calum Lind
ac011d7f55
[Tests] Remove deprecated pip cache setting from travis config
2016-11-03 10:45:01 +00:00
Calum Lind
03c7a2b108
[Common] Refactor unit functions
2016-11-03 10:45:01 +00:00
Calum Lind
ca83ed79c5
[Lint] Pylint enable simple-if-statement
2016-11-03 10:45:01 +00:00
bendikro
54685226c4
[Tests] Remove redundant pillow dep from tox
2016-11-03 10:45:01 +00:00
bendikro
61b059f015
[Lint] Fix couple of pylint complaints
2016-11-03 10:45:01 +00:00
bendikro
f96b9c8a23
[Lint] Enable pylint warning super-init-not-called
2016-11-03 10:45:00 +00:00
Calum Lind
d8242b4ef0
[Lint] Replace R with actual symbols in Pylint rcfile
2016-11-03 10:45:00 +00:00
Calum Lind
f664fcb7a6
[Lint] Update pylint rcfile
...
* Merge in pylint 1.6.4 rcfile changes.
* Add future_builtins to redefined-builtins-modules ignore list. (should be pylint default!)
- Removed pylint disable comments from files.
* Rearrange disable section, comments must be at start of line but can be
interspersed to highlight categories.
* Conventions enabled:
wrong-import-position
wrong-import-order
2016-11-03 10:45:00 +00:00
Calum Lind
5c7a4549f7
[Tests] Add pillow dep so pylint parses Win32IconImagePlugin
2016-11-03 10:45:00 +00:00
bendikro
a04718ebe5
[ #2797 ][Lint] Enable no-init pylint warning
2016-11-03 10:44:48 +00:00
bendikro
59d8fc9a14
[Lint] Fix pylint warnings
2016-11-03 10:31:38 +00:00
Calum Lind
a438f13647
Rename classic to standalone
2016-11-02 23:14:05 +00:00
Calum Lind
23ba57313a
[Core] Support new libtorrent 1.1 alert and status attributes
...
* Keep deprecated lt attribute support for the interim.
2016-11-02 22:08:28 +00:00
Calum Lind
7f24a1a42d
[Core] Add support for new lt settings_pack
2016-11-02 22:08:21 +00:00
Calum Lind
05566894ad
[Core] [UI] Remove deprecated lt extensions
...
* These extensions have been deprecated in 1.1 so simply remove usage.
2016-11-02 21:55:53 +00:00
Calum Lind
4dc59b5255
[Core] Remove compact allocation references
...
* This has been removed from lt 1.1 so no longer relevant.
2016-11-02 21:55:24 +00:00
Calum Lind
08192033fb
[GTKUI] Refactor piecesbar code
2016-11-01 14:27:50 +00:00
bendikro
2f4cb0156c
[Tests] Fix for isort config package handling
...
* Force gtk modules to be third_party for tox/travis testing.
2016-11-01 14:04:14 +00:00
bendikro
e26a3dc0e7
[Tests] Move test torrents into data subdir
2016-11-01 12:28:08 +00:00
bendikro
e827420569
[Tests] Increase file descriptor limit
...
Increase the file descriptor limit to avoid 'Too many files open'
error when running tests.
2016-11-01 12:28:08 +00:00
bendikro
e379e035c7
[ #2849 ] Fix WebUI error without translation MO file
2016-11-01 12:05:36 +00:00
bendikro
6de2813c3d
[ #2784 ] Fix typo in bugfix 5f92810f
2016-11-01 11:57:11 +00:00