codex-storage/deluge
1
0
Fork 0
mirror of https://github.com/codex-storage/deluge.git synced 2025-01-13 21:14:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

[GTKUI] Fix Add Dialog tooltip text needing escaped

Browse Source 
- An ampersand in torrent name would cause the tooltip to not be
displayed.
 - Also switched from cgi to xml.sax for escaping.
This commit is contained in:
Calum Lind 2016-05-10 15:01:50 +01:00
parent 42c3580bf2
commit 9e92178357
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
deluge/ui/gtkui/addtorrentdialog.py
View File

@ -8,9 +8,9 @@
#
import base64
import cgi
import logging
import os
from xml.sax.saxutils import escape as xml_escape
import gobject
import gtk
@ -198,7 +198,7 @@ class AddTorrentDialog(component.Component):
already_added += 1
continue
new_row = self.torrent_liststore.append([info.info_hash, info.name, filename])
new_row = self.torrent_liststore.append([info.info_hash, info.name, xml_escape(filename)])
self.files[info.info_hash] = info.files
self.infos[info.info_hash] = info.filedata
self.listview_torrents.get_selection().select_iter(new_row)
@ -231,7 +231,7 @@ class AddTorrentDialog(component.Component):
if magnet["info_hash"] in self.infos:
log.info("Torrent already in Add Dialog list: %s", uri)
continue
new_row = self.torrent_liststore.append([magnet["info_hash"], magnet["name"], cgi.escape(uri)])
new_row = self.torrent_liststore.append([magnet["info_hash"], magnet["name"], xml_escape(uri)])
self.files[magnet["info_hash"]] = magnet["files_tree"]
self.infos[magnet["info_hash"]] = None
self.listview_torrents.get_selection().select_iter(new_row)