codex-storage
/
deluge
mirror of https://github.com/codex-storage/deluge.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix VersionSplit comparison to do a proper compare and not simply 

against the version strings
This commit is contained in:
Andrew Resch 2010-03-21 15:57:53 -07:00
parent 6aacc6e75c
commit 9d13b17a3c
2 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deluge/common.py
View File

@ -525,7 +525,7 @@ class VersionSplit(object):
def __init__(self, ver): def __init__(self, ver):
ver = ver.lower() ver = ver.lower()
vs = ver.split("_") if "_" in ver else ver.split("-") vs = ver.split("_") if "_" in ver else ver.split("-")
self.version = vs[0] self.version = [int(x) for x in vs[0].split(".")]
self.suffix = None self.suffix = None
if len(vs) > 1: if len(vs) > 1:
for s in ("rc", "alpha", "beta", "dev"): for s in ("rc", "alpha", "beta", "dev"):

11
tests/test_versionsplit.py Normal file
View File

@ -0,0 +1,11 @@
from twisted.trial import unittest
from deluge.common import VersionSplit
class VersionSplitTestClass(unittest.TestCase):
def test_compare(self):
vs1 = VersionSplit("0.14.9")
vs2 = VersionSplit("0.14.10")
vs3 = VersionSplit("0.14.5")
self.assertTrue(vs1 > vs3)
self.assertTrue(vs2 > vs1)