codex-storage
/
deluge
mirror of https://github.com/codex-storage/deluge.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure preferencesmanager only changes intended libtorrent session settings.

This commit is contained in:
Chase Sterling 2010-08-26 01:31:53 -04:00
parent c82ba44be8
commit 7ed33192ec
1 changed files with 19 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
deluge/core/preferencesmanager.py
View File

@ -153,7 +153,6 @@ class PreferencesManager(component.Component):
def start(self): def start(self):
self.core = component.get("Core") self.core = component.get("Core")
self.session = component.get("Core").session self.session = component.get("Core").session
self.settings = component.get("Core").settings
self.new_release_timer = None self.new_release_timer = None
# Set the initial preferences on start-up # Set the initial preferences on start-up
@ -172,6 +171,11 @@ class PreferencesManager(component.Component):
if on_set_func: if on_set_func:
on_set_func(key, value) on_set_func(key, value)
def session_set_setting(self, key, value):
settings = self.session.settings()
setattr(settings, key, value)
self.session.set_settings(settings)
def _on_config_value_change(self, key, value): def _on_config_value_change(self, key, value):
self.do_config_set_func(key, value) self.do_config_set_func(key, value)
component.get("EventManager").emit(ConfigValueChangedEvent(key, value)) component.get("EventManager").emit(ConfigValueChangedEvent(key, value))
@ -214,8 +218,7 @@ class PreferencesManager(component.Component):
def _on_set_outgoing_ports(self, key, value): def _on_set_outgoing_ports(self, key, value):
if not self.config["random_outgoing_ports"]: if not self.config["random_outgoing_ports"]:
log.debug("outgoing port range set to %s-%s", value[0], value[1]) log.debug("outgoing port range set to %s-%s", value[0], value[1])
self.settings.outgoing_ports = value[0], value[1] self.session_set_setting("outgoing_ports", (value[0], value[1]))
self.session.set_settings(self.settings)
def _on_set_random_outgoing_ports(self, key, value): def _on_set_random_outgoing_ports(self, key, value):
if value: if value:
@ -224,13 +227,11 @@ class PreferencesManager(component.Component):
def _on_set_peer_tos(self, key, value): def _on_set_peer_tos(self, key, value):
log.debug("setting peer_tos to: %s", value) log.debug("setting peer_tos to: %s", value)
try: try:
self.settings.peer_tos = chr(int(value, 16)) self.session_set_setting("peer_tos", chr(int(value, 16)))
except ValueError, e: except ValueError, e:
log.debug("Invalid tos byte: %s", e) log.debug("Invalid tos byte: %s", e)
return return
self.session.set_settings(self.settings)
def _on_set_dht(self, key, value): def _on_set_dht(self, key, value):
log.debug("dht value set to %s", value) log.debug("dht value set to %s", value)
state_file = deluge.configmanager.get_config_dir("dht.state") state_file = deluge.configmanager.get_config_dir("dht.state")
@ -339,51 +340,39 @@ class PreferencesManager(component.Component):
self.session.set_max_half_open_connections(value) self.session.set_max_half_open_connections(value)
def _on_set_max_connections_per_second(self, key, value): def _on_set_max_connections_per_second(self, key, value):
self.settings.connection_speed = value self.session_set_setting("connection_speed", value)
self.session.set_settings(self.settings)
def _on_set_ignore_limits_on_local_network(self, key, value): def _on_set_ignore_limits_on_local_network(self, key, value):
self.settings.ignore_limits_on_local_network = value self.session_set_setting("ignore_limits_on_local_network", value)
self.session.set_settings(self.settings)
def _on_set_share_ratio_limit(self, key, value): def _on_set_share_ratio_limit(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
self.settings.share_ratio_limit = value self.session_set_setting("share_ratio_limit", value)
self.session.set_settings(self.settings)
def _on_set_seed_time_ratio_limit(self, key, value): def _on_set_seed_time_ratio_limit(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
self.settings.seed_time_ratio_limit = value self.session_set_setting("seed_time_ratio_limit", value)
self.session.set_settings(self.settings)
def _on_set_seed_time_limit(self, key, value): def _on_set_seed_time_limit(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
# This value is stored in minutes in deluge, but libtorrent wants seconds # This value is stored in minutes in deluge, but libtorrent wants seconds
self.settings.seed_time_limit = int(value * 60) self.session_set_setting("seed_time_limit", int(value * 60))
self.session.set_settings(self.settings)
def _on_set_max_active_downloading(self, key, value): def _on_set_max_active_downloading(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
log.debug("active_downloads: %s", self.settings.active_downloads) self.session_set_setting("active_downloads", value)
self.settings.active_downloads = value
self.session.set_settings(self.settings)
def _on_set_max_active_seeding(self, key, value): def _on_set_max_active_seeding(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
log.debug("active_seeds: %s", self.settings.active_seeds) self.session_set_setting("active_seeds", value)
self.settings.active_seeds = value
self.session.set_settings(self.settings)
def _on_set_max_active_limit(self, key, value): def _on_set_max_active_limit(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
log.debug("active_limit: %s", self.settings.active_limit) self.session_set_setting("active_limit", value)
self.settings.active_limit = value
self.session.set_settings(self.settings)
def _on_set_dont_count_slow_torrents(self, key, value): def _on_set_dont_count_slow_torrents(self, key, value):
log.debug("%s set to %s..", key, value) log.debug("%s set to %s..", key, value)
self.settings.dont_count_slow_torrents = value self.session_set_setting("dont_count_slow_torrents", value)
self.session.set_settings(self.settings)
def _on_set_send_info(self, key, value): def _on_set_send_info(self, key, value):
log.debug("Sending anonymous stats..") log.debug("Sending anonymous stats..")
@ -443,8 +432,7 @@ class PreferencesManager(component.Component):
def _on_set_rate_limit_ip_overhead(self, key, value): def _on_set_rate_limit_ip_overhead(self, key, value):
log.debug("%s: %s", key, value) log.debug("%s: %s", key, value)
self.settings.rate_limit_ip_overhead = value self.session_set_setting("rate_limit_ip_overhead", value)
self.session.set_settings(self.settings)
def _on_set_geoip_db_location(self, key, value): def _on_set_geoip_db_location(self, key, value):
log.debug("%s: %s", key, value) log.debug("%s: %s", key, value)
@ -466,10 +454,8 @@ class PreferencesManager(component.Component):
def _on_set_cache_size(self, key, value): def _on_set_cache_size(self, key, value):
log.debug("%s: %s", key, value) log.debug("%s: %s", key, value)
self.settings.cache_size = value self.session_set_setting("cache_size", value)
self.session.set_settings(self.settings)
def _on_set_cache_expiry(self, key, value): def _on_set_cache_expiry(self, key, value):
log.debug("%s: %s", key, value) log.debug("%s: %s", key, value)
self.settings.cache_expiry = value self.session_set_setting("cache_expiry", value)
self.session.set_settings(self.settings)