From 1d68579b57980e23f4171de26e8c4899f790f0ec Mon Sep 17 00:00:00 2001 From: Calum Lind Date: Wed, 12 Feb 2014 11:10:42 +0000 Subject: [PATCH] Mark set_torrent_* methods deprecated --- deluge/core/core.py | 32 ++++++++++++++------------------ deluge/ui/gtkui/menubar.py | 2 +- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/deluge/core/core.py b/deluge/core/core.py index 581ed7dd0..dd9414091 100644 --- a/deluge/core/core.py +++ b/deluge/core/core.py @@ -570,76 +570,79 @@ class Core(component.Component): @export def set_torrent_max_connections(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets a torrents max number of connections""" return self.torrentmanager[torrent_id].set_max_connections(value) @export def set_torrent_max_upload_slots(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets a torrents max number of upload slots""" return self.torrentmanager[torrent_id].set_max_upload_slots(value) @export def set_torrent_max_upload_speed(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets a torrents max upload speed""" return self.torrentmanager[torrent_id].set_max_upload_speed(value) @export def set_torrent_max_download_speed(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets a torrents max download speed""" return self.torrentmanager[torrent_id].set_max_download_speed(value) @export def set_torrent_file_priorities(self, torrent_id, priorities): + # Deprecated method, use set_torrent_options instead + # Used by at least one 3rd party plugin: """Sets a torrents file priorities""" return self.torrentmanager[torrent_id].set_file_priorities(priorities) @export def set_torrent_prioritize_first_last(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets a higher priority to the first and last pieces""" return self.torrentmanager[torrent_id].set_prioritize_first_last(value) - @export - def set_torrent_sequential_download(self, torrent_id, value): - """Toggle sequencial pieces download""" - return self.torrentmanager[torrent_id].set_sequential_download(value) - @export def set_torrent_auto_managed(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the auto managed flag for queueing purposes""" return self.torrentmanager[torrent_id].set_auto_managed(value) @export def set_torrent_stop_at_ratio(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the torrent to stop at 'stop_ratio'""" return self.torrentmanager[torrent_id].set_stop_at_ratio(value) @export def set_torrent_stop_ratio(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the ratio when to stop a torrent if 'stop_at_ratio' is set""" return self.torrentmanager[torrent_id].set_stop_ratio(value) @export def set_torrent_remove_at_ratio(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the torrent to be removed at 'stop_ratio'""" return self.torrentmanager[torrent_id].set_remove_at_ratio(value) @export def set_torrent_move_completed(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the torrent to be moved when completed""" return self.torrentmanager[torrent_id].set_move_completed(value) @export def set_torrent_move_completed_path(self, torrent_id, value): + # Deprecated method, use set_torrent_options instead """Sets the path for the torrent to be moved when completed""" return self.torrentmanager[torrent_id].set_move_completed_path(value) - @export - def set_torrent_super_seeding(self, torrent_id, value): - """Sets the path for the torrent to be moved when completed""" - return self.torrentmanager[torrent_id].set_super_seeding(value) - @export(AUTH_LEVEL_ADMIN) - def set_torrents_owner(self, torrent_ids, username): + def set_owner(self, torrent_ids, username): """Set's the torrent owner. :param torrent_id: the torrent_id of the torrent to remove @@ -657,13 +660,6 @@ class Core(component.Component): self.torrentmanager[torrent_id].set_owner(username) return None - @export - def set_torrents_shared(self, torrent_ids, shared): - if isinstance(torrent_ids, basestring): - torrent_ids = [torrent_ids] - for torrent_id in torrent_ids: - self.torrentmanager[torrent_id].set_options({"shared": shared}) - @export def get_path_size(self, path): """Returns the size of the file or folder 'path' and -1 if the path is diff --git a/deluge/ui/gtkui/menubar.py b/deluge/ui/gtkui/menubar.py index 7e78e5d59..f36666d3b 100644 --- a/deluge/ui/gtkui/menubar.py +++ b/deluge/ui/gtkui/menubar.py @@ -543,5 +543,5 @@ class MenuBar(component.Component): _("There was an error while trying changing ownership."), self.window.window, details=failure.value.logable() ).run() - client.core.set_torrents_owner( + client.core.set_owner( update_torrents, username).addErrback(failed_change_owner)